Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cri-dockerd version to fix a bug that can not download large images #77

Closed
wants to merge 2 commits into from

Conversation

tenzen-y
Copy link
Contributor

Signed-off-by: tenzen-y yuki.iwai.tz@gmail.com

The cri-dockerd v0.2.0 has a critical bug that can not download large container images. And it was resolved in v0.2.6.

ref:

@tenzen-y tenzen-y changed the title Upgrade cri-dockerd version to v0.2.6 Upgrade cri-dockerd version to fix a bug that can not download large images Dec 13, 2022
@manusa manusa self-requested a review December 13, 2022 05:48
@manusa
Copy link
Owner

manusa commented Dec 13, 2022

Nice!
The asset filtering needs to be tuned since now the Linux artifact no longer contains linux in its name. I'll change this if I can later today (feel free to do so yourself if I haven't responded in a few hours).

@tenzen-y
Copy link
Contributor Author

Nice!
The asset filtering needs to be tuned since now the Linux artifact no longer contains linux in its name.

Thanks for the review!

I'll change this if I can later today (feel free to do so yourself if I haven't responded in a few hours).

Thanks for your effort!

@manusa manusa force-pushed the upgrade-cri-dockerd branch 2 times, most recently from d2c39c7 to dd4575a Compare December 13, 2022 17:04
Copy link
Owner

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@tenzen-y
Copy link
Contributor Author

@manusa Thanks for improving a mechanism to install cri-dockerd!

@manusa
Copy link
Owner

manusa commented Dec 13, 2022

@manusa Thanks for improving a mechanism to install cri-dockerd!

still WIP ;)

@tenzen-y
Copy link
Contributor Author

@manusa Thanks for improving a mechanism to install cri-dockerd!

still WIP ;)

:_(

@manusa manusa force-pushed the upgrade-cri-dockerd branch 12 times, most recently from 9b0e9a8 to 0800d2a Compare December 13, 2022 18:42
@manusa manusa force-pushed the upgrade-cri-dockerd branch from 0800d2a to daf5bf1 Compare December 14, 2022 05:33
@manusa
Copy link
Owner

manusa commented Dec 14, 2022

Unfortunately Minikube's support for cri-dockerd v0.2.6 is not there yet (kubernetes/minikube#14724).

I'm trying to figure out a proper way to setup cri-dockerd with a cni plugin, but still no luck.

I'm also not sure if the problems with the ingress and registry extensions are related to this, or to something else.

@tenzen-y
Copy link
Contributor Author

Unfortunately Minikube's support for cri-dockerd v0.2.6 is not there yet (kubernetes/minikube#14724).

I'm trying to figure out a proper way to setup cri-dockerd with a cni plugin, but still no luck.

I'm laso not sure if the problems with the ingress and registry extensions are related to this, or to something else.

@manusa Thanks for clarifying.
Maybe, we need to wait for releasing version included kubernetes/minikube#14827.

@manusa manusa force-pushed the upgrade-cri-dockerd branch 2 times, most recently from f2d1bf7 to c08d74d Compare December 23, 2022 08:28
@manusa manusa force-pushed the upgrade-cri-dockerd branch 2 times, most recently from f29df40 to 2eba8fe Compare April 6, 2023 15:04
tenzen-y and others added 2 commits April 6, 2023 17:49
@manusa manusa force-pushed the upgrade-cri-dockerd branch from 2eba8fe to 91f04b9 Compare April 6, 2023 15:49
@manusa manusa mentioned this pull request Sep 12, 2023
@manusa
Copy link
Owner

manusa commented Sep 12, 2023

Upgrading cri-docker required the update of the complete ecosystem.

After waiting multiple months for everything to work, it seems that the dependency combination provided in #95 does the trick.

Your commit was cherry-picked into that PR, will merge that one while closing this one.

Thx for your contribution.

@manusa manusa closed this in #95 Sep 12, 2023
@tenzen-y
Copy link
Contributor Author

Upgrading cri-docker required the update of the complete ecosystem.

After waiting multiple months for everything to work, it seems that the dependency combination provided in #95 does the trick.

Your commit was cherry-picked into that PR, will merge that one while closing this one.

Thx for your contribution.

Thank you for your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants