Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en] Replace k8s.gcr.io with registry.k8s.io in blogs #40585

Merged
merged 1 commit into from
May 16, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Apr 10, 2023

This PR replaces k8s.gcr.io with registry.k8s.io in two blog posts where I think it kinda makes sense to do so:

  • 2020-01-15-Kubernetes-on-MIPS.md: this blog post talks about what images they built, but both k8s.gcr.io images are available in the registry, so I think updating makes sense
  • 2022-12-22-kubelet-credential-providers/index.md: was referencing k8s.gcr.io, I added registry.k8s.io as well

/assign @sftim
xref #39353
xref kubernetes/k8s.io#4738

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Apr 10, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 10, 2023
@netlify
Copy link

netlify bot commented Apr 10, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d437f01
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6433e31c2e8378000800ef87
😎 Deploy Preview https://deploy-preview-40585--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The registry changes along with added note to explain about the update looks good.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ab68d0258e04799a14a864ac2acffba35e97259e

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 628cfd7 into kubernetes:main May 16, 2023
@xmudrii xmudrii deleted the k8s.gcr.io-removal branch May 16, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants