[zh-cn] Replace k8s.gcr.io with registry.k8s.io in blog #40589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
cncf-cla: yes
xmudrii
commented
Apr 10, 2023
Comment on lines
+228
to
+229
| - `registry.k8s.io/etcd:3.3.15` (镜像自发布以来已更改（以前使用的仓库为 "k8s.gcr.io")) | ||
| - `registry.k8s.io/pause:3.1` (镜像自发布以来已更改（以前使用的仓库为 "k8s.gcr.io")) |
There was a problem hiding this comment.
I copied this sentence from some other document. Can someone please check if it makes any sense in this context?
There was a problem hiding this comment.
You are right. This sentence is a translation of English (image changed since publication - previously used registry "k8s.gcr.io")
/lgtm
Wait for #40585 to merge.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 20a66dfdf89434c7e9d33846d3284f358527a67f
|
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on #40585 to replace k8s.gcr.io with registry.k8s.io in a Chinese translation of Kubernetes on MIPS blog post.
/assign @sftim
xref #39353
xref kubernetes/k8s.io#4738
/hold
for #40585 to get merged first