Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Gateway API Gateway status #3617

Closed
8 tasks done
Tracked by #3445
michaelbeaumont opened this issue Dec 23, 2021 · 3 comments
Closed
8 tasks done
Tracked by #3445

Set Gateway API Gateway status #3617

michaelbeaumont opened this issue Dec 23, 2021 · 3 comments
Assignees
@michaelbeaumont
Labels
area/gateway Built-in Kuma gateway support area/k8s kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@michaelbeaumont
Copy link
Contributor

michaelbeaumont commented Dec 23, 2021 •
edited
Loading

Description

https://gateway-api.sigs.k8s.io/v1alpha2/references/spec/#gateway.networking.k8s.io/v1alpha2.GatewayStatus

Outstanding issues:
@michaelbeaumont michaelbeaumont added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature area/gateway Built-in Kuma gateway support labels Dec 23, 2021
@michaelbeaumont michaelbeaumont mentioned this issue Dec 23, 2021
Merged
@michaelbeaumont michaelbeaumont added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Dec 23, 2021
@michaelbeaumont michaelbeaumont mentioned this issue Dec 23, 2021
Closed
18 tasks
@michaelbeaumont michaelbeaumont mentioned this issue Jan 10, 2022
Closed
2 tasks
@jpeach
Copy link
Contributor

jpeach commented Jan 12, 2022

Decide how to handle non-unique listener names, see feat(gateway): initial support for GatewayStatus.Listeners #3609 (comment)

I was totally wrong on this one. Listener names must be unique within a Gateway, and the CRD has listmap annotations so that the API server enforces that. So it is safe to assume they are unique.

michaelbeaumont added a commit that referenced this issue Jan 12, 2022
@michaelbeaumont
feat(gateway): initial support for GatewayStatus.Listeners (#3609)
4cf463e 
This PR covers ListenerConditionResolvedRefs (i.e. checking certificate references for ReferencePolicy) and Ready conditions.

Part of #3617

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
This was referenced Jan 17, 2022
Merged
Merged
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 17, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@michaelbeaumont michaelbeaumont removed the triage/stale Inactive for some time. It will be triaged again label Feb 17, 2022
This was referenced Mar 1, 2022
Merged
Merged
@michaelbeaumont michaelbeaumont self-assigned this Mar 1, 2022
@michaelbeaumont
Copy link
Contributor Author

Closing now that the major pieces are done. There are future TODOs that will come with #3450 and #3618

michaelbeaumont added a commit that referenced this issue Mar 1, 2022
@michaelbeaumont
feat(gatewayapi): check for Gateway listener conflicts (#3954)
08886f4 
Part of #3617

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this issue Mar 3, 2022
@michaelbeaumont
feat(gatewayapi): check for Gateway listener detached (#3956)
6daaca7 
Part of #3617

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this issue Apr 14, 2022
@michaelbeaumont @SallyBlichWalkMe
feat(gatewayapi): check for Gateway listener conflicts (kumahq#3954)
2493d23 
Part of kumahq#3617

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Sally Blich <sally.blich@walkme.com>
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this issue Apr 14, 2022
@michaelbeaumont @SallyBlichWalkMe
feat(gatewayapi): check for Gateway listener detached (kumahq#3956)
0a5cfe5 
Part of kumahq#3617

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Sally Blich <sally.blich@walkme.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelbeaumont michaelbeaumont

Labels
area/gateway Built-in Kuma gateway support area/k8s kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpeach @michaelbeaumont