Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatewayapi): check for Gateway listener detached #3956

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Mar 1, 2022

Summary

Part of the Gateway API spec (#3617):

https://github.com/kubernetes-sigs/gateway-api/blob/bdfbb8d9a43c0ef3b9cd7d9239dd95fe9d101f1d/apis/v1alpha2/gateway_types.go#L678-L735

Blocked by #3954

Testing

  • Manual testing on Kubernetes

Changelog: feat(gateway): release K8s GatewayAPI as preview

@michaelbeaumont michaelbeaumont changed the title feat(gateway): check for listener detached feat(gatewayapi): check for listener detached Mar 1, 2022
@michaelbeaumont michaelbeaumont force-pushed the feat/gateway_detached_condition branch from 7b78ff9 to 7870766 Compare March 1, 2022 13:02
@michaelbeaumont michaelbeaumont changed the title feat(gatewayapi): check for listener detached feat(gatewayapi): check for Gateway listener detached Mar 1, 2022
@michaelbeaumont michaelbeaumont force-pushed the feat/gateway_detached_condition branch 2 times, most recently from 40f315b to be8cb03 Compare March 1, 2022 15:40
@michaelbeaumont michaelbeaumont marked this pull request as ready for review March 1, 2022 16:01
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner March 1, 2022 16:01
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the feat/gateway_detached_condition branch from be8cb03 to f33d73e Compare March 1, 2022 16:46
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) March 1, 2022 16:46
@michaelbeaumont michaelbeaumont merged commit 6daaca7 into kumahq:master Mar 3, 2022
@michaelbeaumont michaelbeaumont deleted the feat/gateway_detached_condition branch March 3, 2022 09:41
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Apr 14, 2022
Part of kumahq#3617

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Sally Blich <sally.blich@walkme.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants