Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatewayapi): check for Gateway listener conflicts #3954

Merged
merged 1 commit into from
Mar 1, 2022
Merged

feat(gatewayapi): check for Gateway listener conflicts #3954

merged 1 commit into from
Mar 1, 2022

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Mar 1, 2022 •
edited
Loading

@michaelbeaumont michaelbeaumont force-pushed the feat/gateway_conflict_condition branch from 090f9d2 to 6f1b969 Compare March 1, 2022 11:54
@michaelbeaumont michaelbeaumont changed the title feat(gateway): check for listener conflicts feat(gatewayapi): check for listener conflicts Mar 1, 2022
@michaelbeaumont michaelbeaumont force-pushed the feat/gateway_conflict_condition branch from 6f1b969 to 8c8ab54 Compare March 1, 2022 11:55
@michaelbeaumont michaelbeaumont changed the title feat(gatewayapi): check for listener conflicts feat(gatewayapi): check for Gateway listener conflicts Mar 1, 2022
This was referenced Mar 1, 2022
Closed
Merged
@michaelbeaumont michaelbeaumont force-pushed the feat/gateway_conflict_condition branch from 8c8ab54 to 1ad1256 Compare March 1, 2022 14:05
@michaelbeaumont michaelbeaumont marked this pull request as ready for review March 1, 2022 14:05
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner March 1, 2022 14:05
parkanzky
parkanzky approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@parkanzky parkanzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but otherwise looks good to me.

@michaelbeaumont
feat(gatewayapi): check for Gateway listener conflicts
424ab22 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the feat/gateway_conflict_condition branch from 1ad1256 to 424ab22 Compare March 1, 2022 15:20
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) March 1, 2022 15:22
@michaelbeaumont michaelbeaumont disabled auto-merge March 1, 2022 15:22
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) March 1, 2022 15:22
@michaelbeaumont michaelbeaumont merged commit 08886f4 into kumahq:master Mar 1, 2022
@michaelbeaumont michaelbeaumont deleted the feat/gateway_conflict_condition branch March 1, 2022 16:44
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Apr 14, 2022
@michaelbeaumont @SallyBlichWalkMe
feat(gatewayapi): check for Gateway listener conflicts (kumahq#3954)
2493d23 
Part of kumahq#3617

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Sally Blich <sally.blich@walkme.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkanzky parkanzky parkanzky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbeaumont @parkanzky