Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear how to do a "really clean" build #1293

Closed
silvasean opened this issue Aug 26, 2022 · 2 comments
Closed

Unclear how to do a "really clean" build #1293

silvasean opened this issue Aug 26, 2022 · 2 comments
Assignees
@powderluv

Comments

@silvasean
Copy link
Contributor

I noticed that with source build of pytorch we end up caching some artifacts in build_tools/python_deploy (I think?). Can we make sure that we put all built artifacts in the build dir or have really clear docs about everything that gets built and how to clean it?
@powderluv
Copy link
Collaborator

If we run the Release build script we are exposed to:

torch-mlir/build_tools/python_deploy/build_linux_packages.sh

Line 31 in c0630da

# Note that this script is meant to be run on CI and it will pollute both the

That said I think we can fix some of these docker issues by running them as the $USER instead of root. I am trying to clean up and document the artifacts locations in the Docker PR #1234

qedawkins pushed a commit to nod-ai/torch-mlir that referenced this issue Oct 3, 2022
@whitneywhtsang
[Slice] Use builder based interface to generate Krnl loops (llvm#1293)
8bf9c33 
Signed-off-by: Whitney Tsang <whitneyt@ca.ibm.com>
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this issue Oct 3, 2022
@whitneywhtsang
Remove BuildKrnlLoop (llvm#1410)
0cb5427 
The modification to use the builder based interface to generate Krnl loop is completed (llvm#1250, llvm#1283, llvm#1285, llvm#1292, llvm#1293, llvm#1303, llvm#1308, llvm#1314, llvm#1316, llvm#1317, llvm#1326, llvm#1403), and BuildKrnlLoop is no longer needed.

Signed-off-by: Whitney Tsang whitneyt@ca.ibm.com
@silvasean
Copy link
Contributor Author

Development.md now has instructions: https://github.com/llvm/torch-mlir/blob/main/docs/development.md#cleaning-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@powderluv powderluv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@powderluv @silvasean