Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bazel] Run buildifier #1250

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Conversation

sjain-stanford
Copy link
Member

@sjain-stanford sjain-stanford commented Aug 19, 2022

Lint all Bazel files (BUILD, WORKSPACE, .bzl, or .sky).

Steps followed:

./utils/bazel/run_docker.sh

# run within container
git clone https://github.com/bazelbuild/buildtools.git
cd buildtools
bazel build //buildifier
# buildifier formatter
./bazel-bin/buildifier/buildifier_/buildifier -r ../utils/bazel/
# buildifier linter
./bazel-bin/buildifier/buildifier_/buildifier --lint=fix -r ../utils/bazel/

@sjain-stanford
Copy link
Member Author

sjain-stanford commented Aug 19, 2022

@sjain-stanford sjain-stanford merged commit 1e1759c into llvm:main Aug 19, 2022
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
* [ClipOp]: Use builder based interface to generate Krnl loops

Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com>

* [TileOp]: Use builder based interface to generate Krnl loops

Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com>

* [Transpose]: Use builder based interface to generate Krnl loops

Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com>

* [Transpose]: Remove #ifdef out code

Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com>

* [Split]: Use builder based interface to generate Krnl loops

Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com>

* Address code review comments

Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com>

Co-authored-by: Tung D. Le <tung@jp.ibm.com>
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
The modification to use the builder based interface to generate Krnl loop is completed (llvm#1250, llvm#1283, llvm#1285, llvm#1292, llvm#1293, llvm#1303, llvm#1308, llvm#1314, llvm#1316, llvm#1317, llvm#1326, llvm#1403), and BuildKrnlLoop is no longer needed.

Signed-off-by: Whitney Tsang whitneyt@ca.ibm.com
@sjain-stanford sjain-stanford deleted the sambhav/buildifier branch November 15, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant