Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MHLO] Add torch-to-mhlo e2e support for aten.gather op #1410

Merged
merged 2 commits into from
Sep 25, 2022

Conversation

Vremold
Copy link
Collaborator

@Vremold Vremold commented Sep 23, 2022

No description provided.

Copy link
Collaborator

@tanyokwok tanyokwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Vremold ! It LGTM with a minor comment on the e2e test.

Copy link
Collaborator

@tanyokwok tanyokwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vremold Vremold merged commit ab7aa01 into llvm:main Sep 25, 2022
@Vremold
Copy link
Collaborator Author

Vremold commented Sep 25, 2022

Merged. Thanks @tanyokwok @silvasean !

@Vremold Vremold deleted the gather-op branch September 25, 2022 14:08
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
The modification to use the builder based interface to generate Krnl loop is completed (llvm#1250, llvm#1283, llvm#1285, llvm#1292, llvm#1293, llvm#1303, llvm#1308, llvm#1314, llvm#1316, llvm#1317, llvm#1326, llvm#1403), and BuildKrnlLoop is no longer needed.

Signed-off-by: Whitney Tsang whitneyt@ca.ibm.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants