This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is more a question/discussion than an actual fix, it attempts to fix the issue from #13672:
This issue is that I'm unable to define a crossing antimerdian bounds that plays well with
Transform::setLatLngBounds
. After briefly looking into the possibilities, I believe that creating suchbounds, with constructor
Bounds(sw, ne)
, can in theory be done with:Bounds(LatLng(-20;-170), LatLng(20;170))
// by switching the sw/ne orderBounds(LatLng(-20;170), LatLng(20;190))
// going over max longitude = crosses IDLThe former approach is taken with gl-js as shown here but not possible on gl-native as this generates an invalid bounds by definition here (though this could be changed?).
For now, this has led me down the road to try optimizing for the latter case in this PR.
Current state of this PR works well for my specific setup:
But I'm very sure that this line will impact other parts of the code and thus not a correct change.
Would someone be able to 👀 this and provide some feedback/context?
cc @ansis @ryanhamley @brunoabinader @tmpsantos