Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Hierarchy Builder #42

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Jun 3, 2021

No description provided.

@proux01 proux01 marked this pull request as draft May 20, 2022 09:19
@proux01 proux01 force-pushed the hierarchy-builder branch 3 times, most recently from f7a220d to 15fd021 Compare August 18, 2022 09:48
@proux01 proux01 force-pushed the hierarchy-builder branch 4 times, most recently from 9365627 to 5465b2c Compare August 29, 2022 21:45
@proux01 proux01 force-pushed the hierarchy-builder branch 2 times, most recently from 0867120 to c09f079 Compare May 24, 2023 06:58
@proux01
Copy link
Contributor Author

proux01 commented May 24, 2023

@CohenCyril CI is as green as it can be

@proux01 proux01 marked this pull request as ready for review June 6, 2023 08:30
@CohenCyril
Copy link
Member

CohenCyril commented Jun 6, 2023

@CohenCyril wrote:

I'm afraid this conflicts a bit with #80 which performs a huge cleanup, and which I was about to review and probably merge. @pi8027 @proux01 how would you prefer to handle this?

@proux01 wrote:

@CohenCyril note that this actually is a single char change: 48aef72

The actual question is the interaction between #80 and #42 If #80 is merged rapidly, I'm fine rebasing #42 on top of it, otheriwse I really think we shouldn't wait too much to merge the HB port now that MC 2 is out (not having multinomials means not having CoqEAL which makes MC2 not yet usable for many users). Maybe the best solution is to merge #42 now and rebase #80 (I can help if needed but this should be relatively easy from what I can see, it doesn't seem to really touch the structures).

Sorry for posting in the wrong place. I agree with you and both solutions seem fine as long as one is merged ASAP. I just don't want to pull the rug out from under @pi8027.

Perhaps it's wiser to merge the HB port first though?

@pi8027
Copy link
Member

pi8027 commented Jun 6, 2023

For me, the primary motivation for refactoring multinomials right now is proving an untyping theorem for metrices. I can live with either MC1 or MC2.

@proux01
Copy link
Contributor Author

proux01 commented Jun 6, 2023

Ok, so let's merge #42 first and I'll rebase #80 right after

@CohenCyril CohenCyril merged commit eafee93 into math-comp:master Jun 7, 2023
@proux01 proux01 deleted the hierarchy-builder branch June 7, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants