Cleanup/refactor freeg.v and monalg.v #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2023
|
@pi8027 here is the rebase I promised https://github.com/proux01/multinomials/tree/cleanup (I don't have push rights here so I let you retrieve it) |
|
@proux01 Thanks a lot! Done. |
proux01
approved these changes
Jun 12, 2023
- rename `m_scope` to `monom_scope`,
- rename some definitions to follow the naming convention of MathComp, e.g.,
`cmone` -> `onecm`,
- remove the `{finsfun K -> T / x}` notation (use `{fsfun K -> T with x}`
instead),
- remove the `malg_val` coercion since it is confusing,
- turns `malgC` from a definition into a notation and some lemmas about `malgC`
are subsumed by ones about `mkmalgU`.
|
Can we merge this? |
|
I didn't even realized this wasn't merged yet. I don't have rights but I'm all in favor of merging. Pinging @CohenCyril (don't know who else has merge rights) |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.