Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to https://github.com/math-comp/math-comp/pull/1031 #81

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Jun 6, 2023

No description provided.

@CohenCyril
Copy link
Member

I'm afraid this conflicts a bit with #80 which performs a huge cleanup, and which I was about to review and probably merge.
@pi8027 @proux01 how would you prefer to handle this?

@proux01
Copy link
Contributor Author

proux01 commented Jun 6, 2023

@CohenCyril note that this actually is a single char change: 48aef72

The actual question is the interaction between #80 and #42
If #80 is merged rapidly, I'm fine rebasing #42 on top of it, otheriwse I really think we shouldn't wait too much to merge the HB port now that MC 2 is out (not having multinomials means not having CoqEAL which makes MC2 not yet usable for many users).
Maybe the best solution is to merge #42 now and rebase #80 (I can help if needed but this should be relatively easy from what I can see, it doesn't seem to really touch the structures).

@pi8027 pi8027 merged commit b5bf55f into math-comp:master Jun 12, 2023
@proux01 proux01 deleted the mc_1031 branch June 12, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants