-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fetch all factory deps for a given contract #316
Merged
Merged
Changes from 25 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
1873d96
fix(compile:zk): use factory deps from compilation
Karrq e7a1264
algo
8631f6c
feat(create:zk): fetch all unique factory deps
Karrq 4ce160c
move fetch factory deps to FindContract trait
75f82b8
fix(zkvm:broadcast): fetch all factory_deps
Karrq 36f32f7
fix(zkvm:create): fetch all factory deps
Karrq 96bcb0e
chore: cleanup & todos
Karrq 44a5778
tests(zk): add `Factory` family of tests
Karrq 9d44a95
refactor: dedicated `DualCompiledContracts`
Karrq 78199a4
fix(test:zk): Factory contract cleanup
Karrq 5a1a8b3
fix(call:zk): pass factory deps
Karrq b776171
chore: fmt
Karrq b274948
fix(zk:create): restore handle `--factory-deps`
Karrq fdcf193
refactory(test:zk): split Factory tests & sources
Karrq 0cd560c
Merge branch 'dev' into fix/nested-factory-deps
HermanObst e7cbe94
chore(docs): formatting
Karrq 57a8720
feat(zkvm): persist seen factory deps
Karrq 4a747c3
chore: lints
Karrq b18d559
add docs
nbaztec 0396e6b
fix(zk:etch): avoid `to_checked`
Karrq 58521b3
Merge remote-tracking branch 'origin/dev' into fix/nested-factory-deps
Karrq b0b1309
refactor: persisted_factory_deps field as pub
Karrq ee9b7fa
fix(zk:storage): read from persisted first
Karrq 615e7eb
feat(zk): `ZKVMData::with_extra_factory_deps`
Karrq 4c8b5fd
Merge branch 'dev' into fix/nested-factory-deps
Karrq dcc0f91
docs(zk): factory deps explanations
Karrq 81616fa
Merge branch 'dev' into fix/nested-factory-deps
HermanObst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow up, we should try to remove this part, and perhaps extend it only with the
bytecodes
returned from the era vm. So in theory, every known bytecode will reside here. Or perhaps we can also think if it's easier to support it directly in theBackend
and via some changes toDatabaseExt
to actually store the factory_deps directly in the storage. But that all can be a later refactor.