Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Carthage instructrions #129

Merged
merged 2 commits into from
May 29, 2019
Merged

Conversation

unipheas
Copy link
Contributor

Added instructions for importing the built Carthage frameworks into an Xcode project.

Added instructions for importing the built Carthage frameworks into an Xcode project.
README.md Outdated
@@ -19,9 +19,44 @@ github "Dronecode/DronecodeSDK-Swift" ~> 0.3.0
And then get the framework using:

```shell
rm -rf Carthage ~/Library/Caches/org.carthage.CarthageKit ~/Library/Caches/carthage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would note that this cleaning the caches is sometimes needed if something goes wrong. I would probably not advise to always delete it no matter what.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe add that to a "Troubleshooting" section for Carthage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that.

Created a troubleshooting section and moved the clearing cache section into it.
@JonasVautherin JonasVautherin merged commit 97d04a5 into master May 29, 2019
@JonasVautherin JonasVautherin deleted the add-carthage-instructions branch May 29, 2019 06:48
@JonasVautherin
Copy link
Collaborator

Thanks!

@unipheas
Copy link
Contributor Author

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants