feat: Add Sell Data for Data Market Module #255

inchori · 2022-01-18T05:46:41Z

What I done

Configure tx.proto file and msg_server_deal.go.
Write SellOwnData function in keeper/deal.go .
Write Test Code for SellOwnData function.

TODO

Verification for DataValidator Signature.
Replace max_num_data field and cur_num_data field with pricePerData.
Command-Line for SellData for Tx.

This branch will be base branch for SellData feature.

…ABLED var

…Line

x/market/keeper/deal.go

x/market/types/keys.go

gyuguen

Thank you. I put a few comments

x/market/keeper/deal.go

x/market/types/keys.go

x/market/types/message_deal.go

0xHansLee

Thanks @inchori for your works. I left a few comments more for this pr. If you have any question of thoughts, feel free to mention me!

x/market/keeper/deal.go

x/market/types/keys.go

x/market/types/message_deal.go

x/market/keeper/deal_test.go

inchori · 2022-01-24T05:01:08Z

@youngjoon-lee @hansol-medi Thanks for yours feedback! Could you review or approve #260 this branch first please? I will merge it to this branch and keep working!

…line (#260) Co-authored-by: gyuguen <gyuguen.jang@medibloc.org>

youngjoon-lee

Great job. I think this PR can be merged as long as some comments above are resolved.

inchori · 2022-01-25T07:00:47Z

TODO

Failure cases test code for not only CreateDeal, but also SellData.
Change field name cur_num_data and max_num_data to price_per_data in deactivate-deal feature.

0xHansLee

Many reviews have been resolved.
I think you might miss few points and I commented.

x/market/keeper/deal.go

x/market/types/message_deal.go

proto/panacea/market/v2/tx.proto

x/market/client/cli/tx.go

x/market/keeper/deal.go

0xHansLee · 2022-02-03T08:13:31Z

x/market/client/cli/txDeal.go

@@ -119,17 +120,32 @@ func NewSellDataMsg(clientCtx client.Context, txf tx.Factory, fs *flag.FlagSet)
 		return txf, nil, fmt.Errorf("failed to parse data certificate file: %w", err)
 	}

+	encryptedDataUrlBytes, err := base64.URLEncoding.DecodeString(sellData.Cert.UnsignedCert.EncryptedDataUrlBase64)


In data validator, base64.StdEncoding is used for encoding encryptedDataUrl.
It seems to use the same encoding method because they use different 2 characters

StdEncoding : ABCD...0123456789+/

UrlEncoding : ABCD...0123456789-_

Oh, I missed this part in the previous PR.
I think base64.UrlEncoding should be written in the URL or file name.
The field EncryptedDataUrlBase64 has a URL in its name, but it is actually encrypted String data, so it seems better to use base64.StdEncoding, a standard Base64 encoding.

I didn't know there have a difference between StdEncoding and UrlEncoding. Thank you!

0xHansLee

LGTM!

youngjoon-lee

Good!

gyuguen · 2022-02-04T02:36:37Z

app/config.go

@@ -0,0 +1,61 @@
+package app


I think it would be better to put this commit in the next pr.
This is because new features have already been approvaed by other reviewers before they are uploaded.

This reverts commit b133eaf.

inchori and others added 18 commits December 21, 2021 18:36

fix: Modify Dockerfile for Cosmwasm static linking

a340d75

fix: Change final image alpine to ubuntu in Dockerfile

25d407d

fix: Change wasmvm version from 0.16.2 to 0.14.0 and remove LEDGER_EN…

092a38d

…ABLED var

fix: Add libusb-dev library

777bfce

feat: Add Create Deal for Data Market

38c4e44

fix: golangci-lint hash_test.go

e23d538

fix: Fix TestCreatNewDeal test

f98b905

Merge branch 'master' into ft/na/market/create-deal

ee74bd8

feat: Cmd Create Deal

04a622c

fix

b3ae1e9

fix

d3ed6b1

fix & refactor

0bb0d6e

fix

de45a4b

fix: test

d9f3824

feat: Add Query Single Deal for Data Market Module (#253)

6fbd3bd

fix: Add validation for MsgCreateDeal (#254)

7f1d793

refactor

3ff69ac

feat: Add Sell Data for Data Market Module

52c49fa

inchori requested review from cl9200, gyuguen and youngjoon-lee as code owners January 18, 2022 05:46

inchori requested a review from 0xHansLee January 18, 2022 05:47

inchori added 2 commits January 18, 2022 14:58

fix

b4500f7

fix test

934ac4b

inchori added this to the DataMarket M1 milestone Jan 18, 2022

inchori added 3 commits January 19, 2022 14:40

feat: Apply Signature Verification for SellData and Build Tx Command-…

c1012f2

…Line

fix golangci-lint

34da22f

test: Test code for Verifiy method

c727fe4

0xHansLee reviewed Jan 19, 2022

View reviewed changes

gyuguen reviewed Jan 20, 2022

View reviewed changes

fix

f407ea7

0xHansLee reviewed Jan 24, 2022

View reviewed changes

inchori and others added 4 commits January 24, 2022 14:15

fix

be05dee

fix and resolve

143ff93

fix

402d2ea

feat: Apply Signature Verification for SellData and Build Tx Command-…

8013bf9

…line (#260) Co-authored-by: gyuguen <gyuguen.jang@medibloc.org>

youngjoon-lee approved these changes Jan 24, 2022

View reviewed changes

inchori added 2 commits January 25, 2022 15:26

fix

42ae454

fix & resolve

5a70c8b

inchori requested review from gyuguen and 0xHansLee January 25, 2022 07:00

0xHansLee reviewed Jan 25, 2022

View reviewed changes

x/market/keeper/deal.go Show resolved Hide resolved

x/market/keeper/deal.go Outdated Show resolved Hide resolved

x/market/types/message_deal.go Outdated Show resolved Hide resolved

gyuguen reviewed Jan 26, 2022

View reviewed changes

proto/panacea/market/v2/tx.proto Outdated Show resolved Hide resolved

x/market/client/cli/tx.go Outdated Show resolved Hide resolved

x/market/keeper/deal.go Outdated Show resolved Hide resolved

inchori and others added 5 commits January 26, 2022 14:53

fix and resolve review

24d36b1

fix

47b7b02

test failure keeper_test

0a8ffba

test failure keeper_test

06a9369

fix: Fix data type of some fields (#261)

fffdcf8

0xHansLee reviewed Feb 3, 2022

View reviewed changes

0xHansLee approved these changes Feb 3, 2022

View reviewed changes

youngjoon-lee approved these changes Feb 3, 2022

View reviewed changes

fix

b133eaf

inchori requested a review from gyuguen February 4, 2022 01:26

gyuguen reviewed Feb 4, 2022

View reviewed changes

inchori added 2 commits February 4, 2022 13:58

Revert "fix"

e24b94c

This reverts commit b133eaf.

fix

e26268d

inchori merged commit fd49aba into master Feb 4, 2022

inchori deleted the ft/na/market/sell-data branch February 4, 2022 05:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add Sell Data for Data Market Module #255

feat: Add Sell Data for Data Market Module #255

inchori commented Jan 18, 2022

gyuguen left a comment

0xHansLee left a comment

inchori commented Jan 24, 2022

youngjoon-lee left a comment

inchori commented Jan 25, 2022 •

edited

Loading

0xHansLee left a comment

0xHansLee Feb 3, 2022

gyuguen Feb 3, 2022 •

edited

Loading

inchori Feb 4, 2022

0xHansLee left a comment

youngjoon-lee left a comment

gyuguen Feb 4, 2022

feat: Add Sell Data for Data Market Module #255

feat: Add Sell Data for Data Market Module #255

Conversation

inchori commented Jan 18, 2022

gyuguen left a comment

Choose a reason for hiding this comment

0xHansLee left a comment

Choose a reason for hiding this comment

inchori commented Jan 24, 2022

youngjoon-lee left a comment

Choose a reason for hiding this comment

inchori commented Jan 25, 2022 • edited Loading

0xHansLee left a comment

Choose a reason for hiding this comment

0xHansLee Feb 3, 2022

Choose a reason for hiding this comment

gyuguen Feb 3, 2022 • edited Loading

Choose a reason for hiding this comment

inchori Feb 4, 2022

Choose a reason for hiding this comment

0xHansLee left a comment

Choose a reason for hiding this comment

youngjoon-lee left a comment

Choose a reason for hiding this comment

gyuguen Feb 4, 2022

Choose a reason for hiding this comment

inchori commented Jan 25, 2022 •

edited

Loading

gyuguen Feb 3, 2022 •

edited

Loading