Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.28: New faceting index setting #1704

Closed
guimachiavelli opened this issue Jun 7, 2022 · 3 comments · Fixed by #1707 or #1761
Closed

v0.28: New faceting index setting #1704

guimachiavelli opened this issue Jun 7, 2022 · 3 comments · Fixed by #1707 or #1761
Assignees
@guimachiavelli
Milestone
v0.28

Comments

@guimachiavelli
Copy link
Member

guimachiavelli commented Jun 7, 2022 •
edited
Loading

The new facet search parameter (previously facetsDistribution) will now return a maximum of 100 facets per query by default. The main reasons for this are usability—a query returning a huge number of facets (e.g. 1000) can be difficult to handle properly—and performance—a query returning thousands of facets is likely to be much heavier than it otherwise should.

v0.28 will have a new index setting, faceting. faceting will contain a settings object with one field, maxValuesPerFacet, which accepts an integer and defaults to 100.

faceting will be availabe in the main settings object and its own API route with GET, PATCH and DELETE endpoints.

References

spec: meilisearch/specifications#157
issue on core: meilisearch/meilisearch#2368
SME: @Kerollmops
@guimachiavelli guimachiavelli added this to the v0.28 milestone Jun 7, 2022
@dichotommy
Copy link
Contributor

This will be configurable along with a new index setting: faceting.

Spec: meilisearch/specifications#157

@dichotommy
Copy link
Contributor

I believe the default limit for faceting will be 100 as stated in the spec, not 1000 as stated previously in the core issue. Could someone from @meilisearch/core-team confirm please?

@guimachiavelli guimachiavelli self-assigned this Jun 9, 2022
@curquiza
Copy link
Member

curquiza commented Jun 9, 2022 •
edited
Loading

Yes sorry for the confusion, the default value will be 100, not 1000
I've updated the issue on the core side.

@guimachiavelli guimachiavelli changed the title v0.28: maximum facet value v0.28: New maxValuesPerFacet index setting Jun 13, 2022
@guimachiavelli guimachiavelli changed the title v0.28: New maxValuesPerFacet index setting v0.28: New faceting index setting Jun 13, 2022
@guimachiavelli guimachiavelli mentioned this issue Jun 15, 2022
Merged
@guimachiavelli guimachiavelli linked a pull request Jun 15, 2022 that will close this issue
v0.28 #1707
Merged
@guimachiavelli guimachiavelli mentioned this issue Jun 27, 2022
Merged
@guimachiavelli guimachiavelli linked a pull request Jun 28, 2022 that will close this issue
v0.28: Faceting settings #1761
Merged
bors bot added a commit that referenced this issue Jul 7, 2022
@bors @guimachiavelli @maryamsulemani97
Merge #1761
5dd44ec 
1761: v0.28: Faceting settings r=guimachiavelli a=guimachiavelli

Closes #1704 

Co-authored-by: gui machiavelli <hey@guimachiavelli.com>
Co-authored-by: gui machiavelli <gui@meilisearch.com>
Co-authored-by: Maryam <90181761+maryamsulemani97@users.noreply.github.com>
bors bot added a commit that referenced this issue Jul 11, 2022
@bors @guimachiavelli
@dichotommy @maryamsulemani97
Merge #1707
00cb6df 
1707: v0.28 r=guimachiavelli a=guimachiavelli

This is a staging PR for all changes related to Meilisearch v0.28.

Please avoid making changes directly to this PR; instead, create new child branches based off this one.

Closes #1687, #1688, #1691, #1692, #1693, #1694, #1699, #1700, #1701, #1702, #1703, #1704, #1706, #1722, #1727, #561

Co-authored-by: gui machiavelli <hey@guimachiavelli.com>
Co-authored-by: gui machiavelli <gui@meilisearch.com>
Co-authored-by: Tommy Melvin <tommy@meilisearch.com>
Co-authored-by: Maryam Sulemani <maryam@meilisearch.com>
Co-authored-by: Maryam <90181761+maryamsulemani97@users.noreply.github.com>
@bors bors bot closed this as completed in #1707 Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guimachiavelli guimachiavelli

Labels
None yet
Projects
None yet
Milestone
v0.28
Development

Successfully merging a pull request may close this issue.

v0.28 meilisearch/documentation
v0.28: Faceting settings meilisearch/documentation
3 participants
@guimachiavelli @curquiza @dichotommy