Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.28: New pagination setting #1722

Closed
guimachiavelli opened this issue Jun 13, 2022 · 0 comments · Fixed by #1707
Closed

v0.28: New pagination setting #1722

guimachiavelli opened this issue Jun 13, 2022 · 0 comments · Fixed by #1707
Assignees
@guimachiavelli
Milestone
v0.28

Comments

@guimachiavelli
Copy link
Member

guimachiavelli commented Jun 13, 2022 •
edited
Loading

With v0.27, Meilisearch introduced a hardcoded limit restricting the amount of search results a query can return to 1000.

In v0.28, this harcoded limit will be a configurable index setting, pagination. pagination accepts a settings object with one field, limitedTo maxTotalHits, which accepts an integer and has a default value of 1000.

Users may update the full settings object or use the direct API route indexes/:index/settings/pagination with GET, PATCH, and DELETE endpoints.

When implementing this change in the docs, we should review the hardcoded limits from the "Known limitations" page. When doing so, we should take into account that the current text can be confusing and might not properly explain how the search results limit interacts with the limit and offset search parameters.

Reference
@guimachiavelli guimachiavelli added this to the v0.28 milestone Jun 13, 2022
@guimachiavelli guimachiavelli self-assigned this Jun 13, 2022
@guimachiavelli guimachiavelli mentioned this issue Jun 15, 2022
Merged
@guimachiavelli guimachiavelli linked a pull request Jun 15, 2022 that will close this issue
v0.28 #1707
Merged
This was referenced Jun 27, 2022
Closed
Merged
bors bot added a commit that referenced this issue Jul 5, 2022
@bors @guimachiavelli @maryamsulemani97
Merge #1759
431c864 
1759: v0.28: Pagination settings r=maryamsulemani97 a=guimachiavelli

Closes #1722 

Note for reviewers: you may ignore the failed CI checks, as they are currently failing due to a link to a document created in another PR.

Co-authored-by: gui machiavelli <hey@guimachiavelli.com>
Co-authored-by: gui machiavelli <gui@meilisearch.com>
Co-authored-by: Maryam Sulemani <maryam@meilisearch.com>
Co-authored-by: Maryam <90181761+maryamsulemani97@users.noreply.github.com>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
bors bot added a commit that referenced this issue Jul 11, 2022
@bors @guimachiavelli
@dichotommy @maryamsulemani97
Merge #1707
00cb6df 
1707: v0.28 r=guimachiavelli a=guimachiavelli

This is a staging PR for all changes related to Meilisearch v0.28.

Please avoid making changes directly to this PR; instead, create new child branches based off this one.

Closes #1687, #1688, #1691, #1692, #1693, #1694, #1699, #1700, #1701, #1702, #1703, #1704, #1706, #1722, #1727, #561

Co-authored-by: gui machiavelli <hey@guimachiavelli.com>
Co-authored-by: gui machiavelli <gui@meilisearch.com>
Co-authored-by: Tommy Melvin <tommy@meilisearch.com>
Co-authored-by: Maryam Sulemani <maryam@meilisearch.com>
Co-authored-by: Maryam <90181761+maryamsulemani97@users.noreply.github.com>
@bors bors bot closed this as completed in #1707 Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guimachiavelli guimachiavelli

Labels
None yet
Projects
None yet
Milestone
v0.28
Development

Successfully merging a pull request may close this issue.

v0.28 meilisearch/documentation
1 participant
@guimachiavelli