feat(ui): Isolate rikaikun popup from host page via shadow DOM and all: revert
#933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
人 does not have any verb forms meaning the display of the extra furigana isn't tested.
…ll: revert` - Creates a div inside of shadow root to contain all styles and modifications. - Updates CSS to use `all: revert` instead of previous adhoc reset. - Installs CSS directly into the shadow DOM as per best practices. - Fallsback to `all: initial` for older Chrome browsers. - Removes special check for text files since chrome renders them as normal HTML pages. Fixes #221
Codecov Report
@@ Coverage Diff @@
## main #933 +/- ##
==========================================
+ Coverage 75.83% 76.44% +0.60%
==========================================
Files 7 7
Lines 3000 2984 -16
Branches 162 161 -1
==========================================
+ Hits 2275 2281 +6
+ Misses 724 702 -22
Partials 1 1
Continue to review full report at Codecov.
|
|
Will ignore codecov this time since it's caused by variable name change only and the previous lines were also uncovered. |
melink14
pushed a commit
that referenced
this pull request
Apr 4, 2022
## [2.3.0](v2.2.5...v2.3.0) (2022-04-04) ### Features * **ui:** Isolate rikaikun popup from host page via shadow DOM and `all: revert` ([#933](#933)) ([e6a6e7a](e6a6e7a)), closes [#221](#221) ### Bug Fixes * **detection:** Copy text affecting style properties of input/textarea elements when creating fake ([#886](#886)) ([23fc0df](23fc0df)), closes [#672](#672) * **dict:** Update dictionaries to latest versions ([#954](#954)) ([deae6f5](deae6f5)) * **ui:** Only show info popups in the main frame of a tab ([#948](#948)) ([90c7b21](90c7b21))
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all: revertinstead of previous adhoc reset.all: initialfor older Chrome browsers.Fixes #221