-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] added installation guide with Homebrew #2414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks again for adding this support @ankane
Thank you both. @StrikerRUS I feel like it probably shouldn't be nested under Clang, since it's already pre-compiled. I'd probably do something like: On macOS, LightGBM can be installed with Homebrew or built using Apple Clang or gcc. Homebrew... Apple Clang... gcc... |
Oh, it was my headache for about an hour when I prepared this PR! Yes, with Homebrew users mostly install pre-compiled bottles. But can these bottles be used with gcc? |
@StrikerRUS As far as I know, the bottles don't require any compiler. Overall, I'm thinking it'd be good to separate out the install and build from source instructions. Currently, it looks like the Homebrew instructions are part of the build from source docs (imho). |
According to the docs, bottle can be treated as compiled binary file. According to this part of formula, bottles are built against AppleClang with libomp. I'm not sure that library linked to libomp can run successfully on system with gomp installed. As a side note it's worth to say that there is a lot of headache with supporting projects with OpenMP, e.g., Lines 71 to 74 in 0237492
UPD: Now I'm sure: So, I think we should inform users about that downloaded bottles will run under AppleClang. For someone it may be important.
Agree! Seems that using your descriptive sentence with the current structure will help. I'll push changes in a little while. |
@ankane It should be more clear now that Homebrew allows installation in contrast to building from sources. |
Thanks @StrikerRUS. I still think it'll be easier for users to understand if it's not under the Apple Clang section (most Homebrew users shouldn't need to know anything about how it was compiled), but understand if you don't agree. |
Closed #2408.