Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] remove evals_result argument of train() function #4882

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

StrikerRUS
Copy link
Collaborator

Refer to #4574.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this, thanks!

@StrikerRUS StrikerRUS merged commit e4c0ca5 into master Dec 23, 2021
@StrikerRUS StrikerRUS deleted the remove_evals_result branch December 23, 2021 01:57
liangz1 added a commit to mlflow/mlflow that referenced this pull request Dec 31, 2021
…on > 3.3.1 (#5206)

The parameter evals_result is removed in the master of lightgbm: microsoft/LightGBM#4882.
The parameter early_stopping_rounds is removed in the master of lightgbm: microsoft/LightGBM#4908.

We should also remove this param in our test.

This PR also fixed the sagemaker test failure.

Signed-off-by: Liang Zhang <liang.zhang@databricks.com>
ankit-db pushed a commit to mlflow/mlflow that referenced this pull request Jan 4, 2022
* Add method to load model input example

Signed-off-by: Matthieu Maitre <mmaitre@microsoft.com>

* Try fixing doc and lint failures

Signed-off-by: Matthieu Maitre <mmaitre@microsoft.com>

* Remove param 'evals_result' 'early_stopping_rounds' in lightgbm version > 3.3.1 (#5206)

The parameter evals_result is removed in the master of lightgbm: microsoft/LightGBM#4882.
The parameter early_stopping_rounds is removed in the master of lightgbm: microsoft/LightGBM#4908.

We should also remove this param in our test.

This PR also fixed the sagemaker test failure.

Signed-off-by: Liang Zhang <liang.zhang@databricks.com>

* Address PR feedback

Signed-off-by: Matthieu Maitre <mmaitre@microsoft.com>

Co-authored-by: Liang Zhang <liang.zhang@databricks.com>
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
13 tasks
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants