[python] remove early_stopping_rounds argument of train() and cv() functions
#4908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
force-pushed
the
remove_early_stop
branch
from
10613cd to
b133600
Compare
StrikerRUS
force-pushed
the
remove_early_stop
branch
from
b133600 to
c7265f8
Compare
StrikerRUS
requested review from
chivee,
guolinke,
henry0312,
hzy46,
jameslamb,
shiyu1994 and
tongwu-sh
as code owners
jameslamb
approved these changes
Dec 24, 2021
I believe this was the last one for the Python-package. 🎉 I can find only one |
|
Excellent! And as a reminder, those were just added in #4685 and won't be removed until 4.1.x (#4685 (comment)) |
Merged
29 tasks
liangz1
added a commit
to mlflow/mlflow
that referenced
this pull request
Dec 31, 2021
…on > 3.3.1 (#5206) The parameter evals_result is removed in the master of lightgbm: microsoft/LightGBM#4882. The parameter early_stopping_rounds is removed in the master of lightgbm: microsoft/LightGBM#4908. We should also remove this param in our test. This PR also fixed the sagemaker test failure. Signed-off-by: Liang Zhang <liang.zhang@databricks.com>
ankit-db
pushed a commit
to mlflow/mlflow
that referenced
this pull request
Jan 4, 2022
* Add method to load model input example Signed-off-by: Matthieu Maitre <mmaitre@microsoft.com> * Try fixing doc and lint failures Signed-off-by: Matthieu Maitre <mmaitre@microsoft.com> * Remove param 'evals_result' 'early_stopping_rounds' in lightgbm version > 3.3.1 (#5206) The parameter evals_result is removed in the master of lightgbm: microsoft/LightGBM#4882. The parameter early_stopping_rounds is removed in the master of lightgbm: microsoft/LightGBM#4908. We should also remove this param in our test. This PR also fixed the sagemaker test failure. Signed-off-by: Liang Zhang <liang.zhang@databricks.com> * Address PR feedback Signed-off-by: Matthieu Maitre <mmaitre@microsoft.com> Co-authored-by: Liang Zhang <liang.zhang@databricks.com>
13 tasks
40 tasks
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #4574.