New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I think PR 1653 broke build for projects using remote theme #1658

Closed

LucySheridan opened this issue May 8, 2018 · 4 comments

Labels

LucySheridan commented May 8, 2018

Description

I am generating GitHub pages referencing the Minimal Mistakes theme remotely, since about a hour ago my builds have failed because of the following error:
Your SCSS file assets/css/main.scss has an error on line 228: Undefined variable: "$gitlab-color".

This appears to coincide with a update that was done in this repo about an hour ago...

The text was updated successfully, but these errors were encountered:

Owner

mmistakes commented May 8, 2018

You have a link to your repo having the issue? I'm using the remote theme to build the docs and all builds have worked fine since this PR.

My guess is you have a custom SCSS file that is overidding the theme's files and is missing the $gitlab-color variable.

mmistakes added the Type: Support label

Author

LucySheridan commented May 8, 2018 via email

Yep - already worked that out... and fixed it. Is there a way to sign up for notification of changes. I was in the middle of presentation on GitHub pages (perfect timing) when this happened... :)

On 8 May 2018 at 12:20, Michael Rose ***@***.***> wrote: You have a link to your repo having the issue? I'm using the remote theme to build the docs and all builds have worked fine since this PR. My guess is you have a custom SCSS file that is overidding the theme's files and is missing the $gitlab-color variable. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1658 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AjcWuQTpqKHaHhH9mDyiBeK7t3ivQ-eiks5twcW_gaJpZM4T27rQ> .

Owner

mmistakes commented May 8, 2018 •

edited

Loading

You're best bet would be to star and "watch" this repo. GitHub will send you emails when commits are pushed so you'll know what's being worked on if you need to react to them due to having a custom build.

mmistakes closed this as completed

Owner

mmistakes commented May 8, 2018

Also, if you want to lock what version of the theme you use vs. being on the bleeding edge of master you can do something like this in your _config.yml file:

remote_theme: mmistakes/minimal-mistakes@4.11.2

okitem pushed a commit to okmalls/okmalls.github.io that referenced this issue


          feat(analytics): add Umami and Matomo tracking codes (mmistakes#1658)

61bdca2

okitem pushed a commit to okmalls/okmalls.github.io that referenced this issue


          chore(release): 7.0.0

e33547f

## [7.0.0](cotes2020/jekyll-theme-chirpy@v6.5.5...v7.0.0) (2024-05-11)

### ⚠ BREAKING CHANGES

* optimize the resource hints (mmistakes#1717)
* rename media-url file and related parameters (mmistakes#1651)
* rename comment setting parameter (mmistakes#1563)
* **analytics:** add post pageviews for GoatCounter (mmistakes#1543)

### Features

* add cloudflare web analytics ([mmistakes#1723](cotes2020/jekyll-theme-chirpy#1723)) ([c17fba4](cotes2020/jekyll-theme-chirpy@c17fba4))
* add support for embed video files ([mmistakes#1558](cotes2020/jekyll-theme-chirpy#1558)) ([9592146](cotes2020/jekyll-theme-chirpy@9592146))
* add support for giscus strict title matching ([mmistakes#1614](cotes2020/jekyll-theme-chirpy#1614)) ([700fd5b](cotes2020/jekyll-theme-chirpy@700fd5b))
* **analytics:** add post pageviews for GoatCounter ([mmistakes#1543](cotes2020/jekyll-theme-chirpy#1543)) ([b641b3f](cotes2020/jekyll-theme-chirpy@b641b3f))
* **analytics:** add Umami and Matomo tracking codes ([mmistakes#1658](cotes2020/jekyll-theme-chirpy#1658)) ([61bdca2](cotes2020/jekyll-theme-chirpy@61bdca2))
* change site verification settings ([mmistakes#1561](cotes2020/jekyll-theme-chirpy#1561)) ([e436387](cotes2020/jekyll-theme-chirpy@e436387))
* **deps:** move `MathJax` configuration to a separate file ([mmistakes#1670](cotes2020/jekyll-theme-chirpy#1670)) ([44f552c](cotes2020/jekyll-theme-chirpy@44f552c))
* display theme version in footer ([mmistakes#1611](cotes2020/jekyll-theme-chirpy#1611)) ([8349314](cotes2020/jekyll-theme-chirpy@8349314))
* **i18n:** allow `page.lang` to override `site.lang` ([mmistakes#1586](cotes2020/jekyll-theme-chirpy#1586)) ([547b95c](cotes2020/jekyll-theme-chirpy@547b95c))
* make post description customizable ([mmistakes#1602](cotes2020/jekyll-theme-chirpy#1602)) ([f865336](cotes2020/jekyll-theme-chirpy@f865336))
* **media:** support audio and video tag with multi sources ([mmistakes#1618](cotes2020/jekyll-theme-chirpy#1618)) ([23be416](cotes2020/jekyll-theme-chirpy@23be416))

### Bug Fixes

* make TOC title and entries visible at the same time ([mmistakes#1711](cotes2020/jekyll-theme-chirpy#1711)) ([e0950fc](cotes2020/jekyll-theme-chirpy@e0950fc))
* mode toggle not outlined when receiving keyboard focus ([mmistakes#1690](cotes2020/jekyll-theme-chirpy#1690)) ([cd37f63](cotes2020/jekyll-theme-chirpy@cd37f63))
* prevent footnote back arrow from becoming an emoji ([mmistakes#1716](cotes2020/jekyll-theme-chirpy#1716)) ([8608147](cotes2020/jekyll-theme-chirpy@8608147))
* **pwa:** skip range requests in service worker ([mmistakes#1672](cotes2020/jekyll-theme-chirpy#1672)) ([76d58fe](cotes2020/jekyll-theme-chirpy@76d58fe))
* search result prompt is empty ([mmistakes#1583](cotes2020/jekyll-theme-chirpy#1583)) ([8a2afae](cotes2020/jekyll-theme-chirpy@8a2afae))
* use `https` for Weibo sharing URL ([mmistakes#1612](cotes2020/jekyll-theme-chirpy#1612)) ([8e5fbb7](cotes2020/jekyll-theme-chirpy@8e5fbb7))

### Improvements

* improve <hr> visibility in dark mode ([mmistakes#1565](cotes2020/jekyll-theme-chirpy#1565)) ([4ddd5c4](cotes2020/jekyll-theme-chirpy@4ddd5c4))
* lean bootstrap javascript ([mmistakes#1734](cotes2020/jekyll-theme-chirpy#1734)) ([ddb48ed](cotes2020/jekyll-theme-chirpy@ddb48ed))
* rename comment setting parameter ([mmistakes#1563](cotes2020/jekyll-theme-chirpy#1563)) ([f8390d4](cotes2020/jekyll-theme-chirpy@f8390d4))
* replace jQuery with Vanilla JS ([mmistakes#1681](cotes2020/jekyll-theme-chirpy#1681)) ([fe7afa3](cotes2020/jekyll-theme-chirpy@fe7afa3))
* simplify mode toggle script ([mmistakes#1692](cotes2020/jekyll-theme-chirpy#1692)) ([d4a6d64](cotes2020/jekyll-theme-chirpy@d4a6d64))
* tree shaking Bootstrap CSS ([mmistakes#1736](cotes2020/jekyll-theme-chirpy#1736)) ([363a3d9](cotes2020/jekyll-theme-chirpy@363a3d9))

### Changes

* optimize the resource hints ([mmistakes#1717](cotes2020/jekyll-theme-chirpy#1717)) ([dcb0add](cotes2020/jekyll-theme-chirpy@dcb0add))
* rename media-url file and related parameters ([mmistakes#1651](cotes2020/jekyll-theme-chirpy#1651)) ([9f8aeaa](cotes2020/jekyll-theme-chirpy@9f8aeaa))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment