Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes required for new version of Susy #1734

Closed
desilinguist opened this issue Jul 5, 2018 · 5 comments
Closed

Changes required for new version of Susy #1734

desilinguist opened this issue Jul 5, 2018 · 5 comments

Comments

@desilinguist
Copy link

desilinguist commented Jul 5, 2018

Description

Understanding how to work with the new version of Susy

Environment


I had figured out how to use Susy for a custom layout -- thanks to your help -- with a previous version of the theme back in early 2017. However, it seems that Susy has changed significantly and my old CSS setup doesn't work. For example, I had the following in _variables.scss under the Grid section:

$susy: (
  columns: 20,
  gutters: 1/4,
  math: fluid,
  output: float,
  gutter-position: after,
  container: $large,
  global-box-sizing: border-box,
);

However, if I change this to the new:

$susy: (
  'columns': susy-repeat(20),
  'gutters': 0.25,
  'spread': 'narrow',
  'container-spread': 'narrow',
);

in the same location, I get the following error:

Error: [su-valid-span] [string] `susy-repeat(20)` is not a valid number, length, or column-list for $span. on line 43

This confuses me as this is the syntax that the Susy3 documentation recommends.

@mmistakes
Copy link
Owner

Not sure. Have you reached out to the Susy maintainers as they would know better than me.

I haven't worked with Susy much recently. The new version from what I remember is less about mixins and "magic" and more about math.

Looking at the error message it's pretty clear... it's expecting a number and you're giving it a string.

@desilinguist
Copy link
Author

desilinguist commented Jul 5, 2018 via email

@mmistakes
Copy link
Owner

Again, probably a better idea to file an issue on Susy's repo. The maintainers there would know more than me as they built it.

@desilinguist
Copy link
Author

desilinguist commented Jul 5, 2018 via email

@desilinguist
Copy link
Author

I figured out that I can just use percentage() for my grid layout directly without needing to use Susy at all.

okitem pushed a commit to okmalls/okmalls.github.io that referenced this issue Sep 21, 2024
okitem pushed a commit to okmalls/okmalls.github.io that referenced this issue Sep 21, 2024
## [7.0.0](cotes2020/jekyll-theme-chirpy@v6.5.5...v7.0.0) (2024-05-11)

### ⚠ BREAKING CHANGES

* optimize the resource hints (mmistakes#1717)
* rename media-url file and related parameters (mmistakes#1651)
* rename comment setting parameter (mmistakes#1563)
* **analytics:** add post pageviews for GoatCounter (mmistakes#1543)

### Features

* add cloudflare web analytics ([mmistakes#1723](cotes2020/jekyll-theme-chirpy#1723)) ([c17fba4](cotes2020/jekyll-theme-chirpy@c17fba4))
* add support for embed video files ([mmistakes#1558](cotes2020/jekyll-theme-chirpy#1558)) ([9592146](cotes2020/jekyll-theme-chirpy@9592146))
* add support for giscus strict title matching ([mmistakes#1614](cotes2020/jekyll-theme-chirpy#1614)) ([700fd5b](cotes2020/jekyll-theme-chirpy@700fd5b))
* **analytics:** add post pageviews for GoatCounter ([mmistakes#1543](cotes2020/jekyll-theme-chirpy#1543)) ([b641b3f](cotes2020/jekyll-theme-chirpy@b641b3f))
* **analytics:** add Umami and Matomo tracking codes ([mmistakes#1658](cotes2020/jekyll-theme-chirpy#1658)) ([61bdca2](cotes2020/jekyll-theme-chirpy@61bdca2))
* change site verification settings ([mmistakes#1561](cotes2020/jekyll-theme-chirpy#1561)) ([e436387](cotes2020/jekyll-theme-chirpy@e436387))
* **deps:** move `MathJax` configuration to a separate file ([mmistakes#1670](cotes2020/jekyll-theme-chirpy#1670)) ([44f552c](cotes2020/jekyll-theme-chirpy@44f552c))
* display theme version in footer ([mmistakes#1611](cotes2020/jekyll-theme-chirpy#1611)) ([8349314](cotes2020/jekyll-theme-chirpy@8349314))
* **i18n:** allow `page.lang` to override `site.lang` ([mmistakes#1586](cotes2020/jekyll-theme-chirpy#1586)) ([547b95c](cotes2020/jekyll-theme-chirpy@547b95c))
* make post description customizable ([mmistakes#1602](cotes2020/jekyll-theme-chirpy#1602)) ([f865336](cotes2020/jekyll-theme-chirpy@f865336))
* **media:** support audio and video tag with multi sources ([mmistakes#1618](cotes2020/jekyll-theme-chirpy#1618)) ([23be416](cotes2020/jekyll-theme-chirpy@23be416))

### Bug Fixes

* make TOC title and entries visible at the same time ([mmistakes#1711](cotes2020/jekyll-theme-chirpy#1711)) ([e0950fc](cotes2020/jekyll-theme-chirpy@e0950fc))
* mode toggle not outlined when receiving keyboard focus ([mmistakes#1690](cotes2020/jekyll-theme-chirpy#1690)) ([cd37f63](cotes2020/jekyll-theme-chirpy@cd37f63))
* prevent footnote back arrow from becoming an emoji ([mmistakes#1716](cotes2020/jekyll-theme-chirpy#1716)) ([8608147](cotes2020/jekyll-theme-chirpy@8608147))
* **pwa:** skip range requests in service worker ([mmistakes#1672](cotes2020/jekyll-theme-chirpy#1672)) ([76d58fe](cotes2020/jekyll-theme-chirpy@76d58fe))
* search result prompt is empty ([mmistakes#1583](cotes2020/jekyll-theme-chirpy#1583)) ([8a2afae](cotes2020/jekyll-theme-chirpy@8a2afae))
* use `https` for Weibo sharing URL ([mmistakes#1612](cotes2020/jekyll-theme-chirpy#1612)) ([8e5fbb7](cotes2020/jekyll-theme-chirpy@8e5fbb7))

### Improvements

* improve <hr> visibility in dark mode ([mmistakes#1565](cotes2020/jekyll-theme-chirpy#1565)) ([4ddd5c4](cotes2020/jekyll-theme-chirpy@4ddd5c4))
* lean bootstrap javascript ([mmistakes#1734](cotes2020/jekyll-theme-chirpy#1734)) ([ddb48ed](cotes2020/jekyll-theme-chirpy@ddb48ed))
* rename comment setting parameter ([mmistakes#1563](cotes2020/jekyll-theme-chirpy#1563)) ([f8390d4](cotes2020/jekyll-theme-chirpy@f8390d4))
* replace jQuery with Vanilla JS ([mmistakes#1681](cotes2020/jekyll-theme-chirpy#1681)) ([fe7afa3](cotes2020/jekyll-theme-chirpy@fe7afa3))
* simplify mode toggle script ([mmistakes#1692](cotes2020/jekyll-theme-chirpy#1692)) ([d4a6d64](cotes2020/jekyll-theme-chirpy@d4a6d64))
* tree shaking Bootstrap CSS ([mmistakes#1736](cotes2020/jekyll-theme-chirpy#1736)) ([363a3d9](cotes2020/jekyll-theme-chirpy@363a3d9))

### Changes

* optimize the resource hints ([mmistakes#1717](cotes2020/jekyll-theme-chirpy#1717)) ([dcb0add](cotes2020/jekyll-theme-chirpy@dcb0add))
* rename media-url file and related parameters ([mmistakes#1651](cotes2020/jekyll-theme-chirpy#1651)) ([9f8aeaa](cotes2020/jekyll-theme-chirpy@9f8aeaa))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants