New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow external link _target #1670

Closed

jamiesmith wants to merge 1 commit into mmistakes:master from jamiesmith:allow-link-targets

Contributor

jamiesmith commented May 12, 2018

I like to have external links have the option to open in a new tab. This allows users to specify that.


          allow external link _target

636cd13

Owner

mmistakes commented May 12, 2018

Thanks for the PR, but I'm not a fan of forcing target="_blank" on the user for all of the reasons cited here: https://css-tricks.com/use-target_blank/

jamiesmith closed this

Contributor Author

jamiesmith commented May 14, 2018

ok

Sciss commented May 14, 2018 •

edited

Loading

You can add another liquid thing: https://github.com/Sciss/minimal-mistakes/blob/homepage2/_plugins/extlink_tag.rb

It works like this:

{% extlink MIBsaal http://www.musikerinitiative-bremen.de/ %}

You can add CSS to .external to highlight external links differently.

okitem pushed a commit to okmalls/okmalls.github.io that referenced this pull request


          feat(deps): move MathJax configuration to a separate file (mmistake…

44f552c

…s#1670)

Move `MathJax` configuration to file `assets/js/data/mathjax.js` will help add extensions.

okitem pushed a commit to okmalls/okmalls.github.io that referenced this pull request


          chore(release): 7.0.0

e33547f

## [7.0.0](cotes2020/jekyll-theme-chirpy@v6.5.5...v7.0.0) (2024-05-11)

### ⚠ BREAKING CHANGES

* optimize the resource hints (mmistakes#1717)
* rename media-url file and related parameters (mmistakes#1651)
* rename comment setting parameter (mmistakes#1563)
* **analytics:** add post pageviews for GoatCounter (mmistakes#1543)

### Features

* add cloudflare web analytics ([mmistakes#1723](cotes2020/jekyll-theme-chirpy#1723)) ([c17fba4](cotes2020/jekyll-theme-chirpy@c17fba4))
* add support for embed video files ([mmistakes#1558](cotes2020/jekyll-theme-chirpy#1558)) ([9592146](cotes2020/jekyll-theme-chirpy@9592146))
* add support for giscus strict title matching ([mmistakes#1614](cotes2020/jekyll-theme-chirpy#1614)) ([700fd5b](cotes2020/jekyll-theme-chirpy@700fd5b))
* **analytics:** add post pageviews for GoatCounter ([mmistakes#1543](cotes2020/jekyll-theme-chirpy#1543)) ([b641b3f](cotes2020/jekyll-theme-chirpy@b641b3f))
* **analytics:** add Umami and Matomo tracking codes ([mmistakes#1658](cotes2020/jekyll-theme-chirpy#1658)) ([61bdca2](cotes2020/jekyll-theme-chirpy@61bdca2))
* change site verification settings ([mmistakes#1561](cotes2020/jekyll-theme-chirpy#1561)) ([e436387](cotes2020/jekyll-theme-chirpy@e436387))
* **deps:** move `MathJax` configuration to a separate file ([mmistakes#1670](cotes2020/jekyll-theme-chirpy#1670)) ([44f552c](cotes2020/jekyll-theme-chirpy@44f552c))
* display theme version in footer ([mmistakes#1611](cotes2020/jekyll-theme-chirpy#1611)) ([8349314](cotes2020/jekyll-theme-chirpy@8349314))
* **i18n:** allow `page.lang` to override `site.lang` ([mmistakes#1586](cotes2020/jekyll-theme-chirpy#1586)) ([547b95c](cotes2020/jekyll-theme-chirpy@547b95c))
* make post description customizable ([mmistakes#1602](cotes2020/jekyll-theme-chirpy#1602)) ([f865336](cotes2020/jekyll-theme-chirpy@f865336))
* **media:** support audio and video tag with multi sources ([mmistakes#1618](cotes2020/jekyll-theme-chirpy#1618)) ([23be416](cotes2020/jekyll-theme-chirpy@23be416))

### Bug Fixes

* make TOC title and entries visible at the same time ([mmistakes#1711](cotes2020/jekyll-theme-chirpy#1711)) ([e0950fc](cotes2020/jekyll-theme-chirpy@e0950fc))
* mode toggle not outlined when receiving keyboard focus ([mmistakes#1690](cotes2020/jekyll-theme-chirpy#1690)) ([cd37f63](cotes2020/jekyll-theme-chirpy@cd37f63))
* prevent footnote back arrow from becoming an emoji ([mmistakes#1716](cotes2020/jekyll-theme-chirpy#1716)) ([8608147](cotes2020/jekyll-theme-chirpy@8608147))
* **pwa:** skip range requests in service worker ([mmistakes#1672](cotes2020/jekyll-theme-chirpy#1672)) ([76d58fe](cotes2020/jekyll-theme-chirpy@76d58fe))
* search result prompt is empty ([mmistakes#1583](cotes2020/jekyll-theme-chirpy#1583)) ([8a2afae](cotes2020/jekyll-theme-chirpy@8a2afae))
* use `https` for Weibo sharing URL ([mmistakes#1612](cotes2020/jekyll-theme-chirpy#1612)) ([8e5fbb7](cotes2020/jekyll-theme-chirpy@8e5fbb7))

### Improvements

* improve <hr> visibility in dark mode ([mmistakes#1565](cotes2020/jekyll-theme-chirpy#1565)) ([4ddd5c4](cotes2020/jekyll-theme-chirpy@4ddd5c4))
* lean bootstrap javascript ([mmistakes#1734](cotes2020/jekyll-theme-chirpy#1734)) ([ddb48ed](cotes2020/jekyll-theme-chirpy@ddb48ed))
* rename comment setting parameter ([mmistakes#1563](cotes2020/jekyll-theme-chirpy#1563)) ([f8390d4](cotes2020/jekyll-theme-chirpy@f8390d4))
* replace jQuery with Vanilla JS ([mmistakes#1681](cotes2020/jekyll-theme-chirpy#1681)) ([fe7afa3](cotes2020/jekyll-theme-chirpy@fe7afa3))
* simplify mode toggle script ([mmistakes#1692](cotes2020/jekyll-theme-chirpy#1692)) ([d4a6d64](cotes2020/jekyll-theme-chirpy@d4a6d64))
* tree shaking Bootstrap CSS ([mmistakes#1736](cotes2020/jekyll-theme-chirpy#1736)) ([363a3d9](cotes2020/jekyll-theme-chirpy@363a3d9))

### Changes

* optimize the resource hints ([mmistakes#1717](cotes2020/jekyll-theme-chirpy#1717)) ([dcb0add](cotes2020/jekyll-theme-chirpy@dcb0add))
* rename media-url file and related parameters ([mmistakes#1651](cotes2020/jekyll-theme-chirpy#1651)) ([9f8aeaa](cotes2020/jekyll-theme-chirpy@9f8aeaa))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet