Skip to content

Commit

Permalink
Fix ignores in merge check (#1117)
Browse files Browse the repository at this point in the history
We renamed CI tests in #1073, but
forgot to rename them in the ignored list for the merge check. This PR
fixes this.
  • Loading branch information
qinsoon authored Apr 16, 2024
1 parent a2b36f4 commit a650e87
Showing 1 changed file with 23 additions and 5 deletions.
28 changes: 23 additions & 5 deletions .github/workflows/merge-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,28 @@ on:
branches:
- master

env:
# Ignore some actions for the merge check:
# - This action itself
# - Public API check, doc broken link check: we allow them to fail.
# - Minimal tests for stable Rust: we allow them to fail.
# - Extended binding tests: it may take long to run. We don't want to wait for them.
IGNORED_ACTIONS: |
[
"ready-to-merge",
"check-broken-links-in-docs",
"check-public-api-changes",
"minimal-tests-core/x86_64-unknown-linux-gnu/stable",
"minimal-tests-core/i686-unknown-linux-gnu/stable",
"minimal-tests-core/x86_64-apple-darwin/stable",
"extended-tests-v8",
"extended-tests-jikesrvm",
"extended-tests-julia",
"extended-tests-openjdk",
"extended-tests-ruby (release)",
"extended-tests-ruby (debug)"
]
jobs:
ready-to-merge:
runs-on: ubuntu-latest
Expand All @@ -16,11 +38,7 @@ jobs:
timeout-minutes: 120
uses: "WyriHaximus/github-action-wait-for-status@v1.8.0"
with:
# Ignore some actions (based on what merge_group triggers):
# - this action
# - minimal tests for stable Rust (we allow them to fail)
# - binding tests (it may take long to run)
ignoreActions: "ready-to-merge,check-broken-links-in-docs,check-public-api-changes,minimal-tests-core/x86_64-unknown-linux-gnu/stable,minimal-tests-core/i686-unknown-linux-gnu/stable,minimal-tests-core/x86_64-apple-darwin/stable,v8-binding-test,openjdk-binding-test,jikesrvm-binding-test,julia-binding-test,ruby-binding-test (release),ruby-binding-test (debug)"
ignoreActions: "${{ join(fromJson(env.IGNORED_ACTIONS)) }}"
# This action uses API. We have a quota of 1000 per hour.
checkInterval: 600
env:
Expand Down

0 comments on commit a650e87

Please sign in to comment.