Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignores in merge check #1117

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Apr 16, 2024

We renamed CI tests in #1073, but forgot to rename them in the ignored list for the merge check. This PR fixes this.

@qinsoon qinsoon added the PR-extended-testing Run extended tests for the pull request label Apr 16, 2024
@qinsoon qinsoon marked this pull request as ready for review April 16, 2024 05:27
@qinsoon qinsoon requested a review from wks April 16, 2024 05:27
"minimal-tests-core/x86_64-apple-darwin/stable",
"extended-tests-v8",
"extended-tests-jikesrvm",
"extended-tests-julia",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget extended-tests-openjdk?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I added it back.

Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon enabled auto-merge April 16, 2024 06:54
@qinsoon qinsoon added this pull request to the merge queue Apr 16, 2024
Merged via the queue into mmtk:master with commit a650e87 Apr 16, 2024
24 checks passed
@qinsoon qinsoon deleted the fix-ignores-in-merge-check branch April 16, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-extended-testing Run extended tests for the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants