Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.5.0 #294

Merged
merged 26 commits into from
Jul 14, 2019
Merged

release 0.5.0 #294

merged 26 commits into from
Jul 14, 2019

Conversation

chfw
Copy link
Member

@chfw chfw commented Jul 14, 2019

see changelog for more details.

jayvdb and others added 26 commits July 8, 2019 14:16
Ensure that this repo is leading by example,
and eating its own dogfood.

Also reduces flake8 ignore list to only W503,W504,
and updates the flake8 max line length to match black.

And separate commands in test.bat with %errorlevel%
handling.
The Python 3.8-dev job has broken on building ruamel.yaml,
and the template doesnt provide control over allowing failures.
Fixes two UnicodeEncodeError's occurring when hashing
and writing files.

Closes #281
This substantially reverts commit 9517891.

The cause of the change has been addressed by an enhancement in
git-url-parse v1.2.1, too late to be included in moban v0.4.0
retr0h/git-url-parse@3e2bf91e

Using giturlparse instead of git-url-parse is a non-trivial breaking change.
It was done to avoid one minor regression which users could workaround,
however it introduced many significant regressions users could not
workaround as giturlparse does not parse many types of URLs.

Closes #277
git-url-parse does not yet (1.2.2) handle trailing slashes,
which are an optional part of all git URLs, but were supported
before the switch to using GitPython.

Closes #277
🚑 fix unicode support on Python 2.7
Re-adds Python 3.4 support, broken by ruamel.yaml desupporting it
in version 0.15.94.
Also adds minimum version for ruamel-yaml on Python 3.7 and 3.8,
and re-adds Python 3.8-dev to the Travis matrix recently removed
in ec48af4 due to temporary build failures.

And avoids newer arrow desupported on Python 3.4.

Fixes #274
add ruamel-yaml pins to aid installation
Fix filename typos in README
📚 prepare changelog for 0.5.0
@chfw chfw requested a review from jayvdb July 14, 2019 14:42
@jayvdb
Copy link
Member

jayvdb commented Jul 14, 2019

I dont understand the benefit of the commit " hammer minimize the changes in setup.py " . The changes already happened in earlier commits. Adding another commit to change them back only makes the commit history more complicated.

And it breaks the moban job, which is designed to stop people doing little "local" hacks like that. :P

@chfw
Copy link
Member Author

chfw commented Jul 14, 2019

Will need remove moban stage.

The minimization would reveal less change in dev to master diff. And the hammer tool is black, which won’t take a minute.

@jayvdb
Copy link
Member

jayvdb commented Jul 14, 2019

I dont understand. If you remove your commit, the build will pass, and the release can be done.

Other problems can then be created as issues and discussed/prioritised normally.

@chfw
Copy link
Member Author

chfw commented Jul 14, 2019

@jayvdb , I am sorry to be a numpty. I did not realize the function of moban stage.

@codecov-io
Copy link

codecov-io commented Jul 16, 2019

Codecov Report

Merging #294 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
+ Coverage   98.94%   98.94%   +<.01%     
==========================================
  Files          60       60              
  Lines        2550     2553       +3     
==========================================
+ Hits         2523     2526       +3     
  Misses         27       27
Impacted Files Coverage Δ
moban/_version.py 100% <100%> (ø) ⬆️
moban/hashstore.py 100% <100%> (ø) ⬆️
moban/reporter.py 100% <100%> (ø) ⬆️
tests/test_repo.py 100% <100%> (ø) ⬆️
moban/utils.py 97.53% <100%> (+0.09%) ⬆️
moban/repo.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 050d94c...fd798a0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants