Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double stdout fixes #393 #394

Merged
merged 39 commits into from
Aug 15, 2020
Merged

Fix double stdout fixes #393 #394

merged 39 commits into from
Aug 15, 2020

Conversation

salotz
Copy link
Contributor

@salotz salotz commented Aug 12, 2020

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?
  • please add your name and github link to contributors.rst in alphabetical order.

Any tips on how to write a test for it?

chfw added 30 commits November 18, 2018 13:59
🥚 🎡 release 0.3.4.1 to fix 0.3.4
release 0.4.1 - patching release date and version
Release 0.6.0 - PyFileSystem2 support
Release 0.6.3 - Template through Unix Pipe (#336)
🥚 🎡 release 0.6.5
👕 pump up version number
:eggs: 🎡 release 0.6.6
🥚 🎡 Release 0.6.7
🥚 🎡 release 0.6.8
release 0.7.2 - use templates over internet
@salotz salotz changed the title Fix stdout Fix double stdout fixes #393 Aug 12, 2020
@chfw
Copy link
Member

chfw commented Aug 13, 2020

Your contribution is welcome!

  1. would you like to run 'make format' on the source code?
  2. would you like to write a unit test for it? here is the unit test I wrote for this feature: https://github.com/moremoban/moban/blob/dev/tests/integration_tests/test_command_line_options.py#L567

@chfw chfw merged commit be6c38f into moremoban:dev Aug 15, 2020
chfw added a commit that referenced this pull request Aug 15, 2020
chfw added a commit that referenced this pull request Aug 15, 2020
@salotz
Copy link
Contributor Author

salotz commented Aug 18, 2020

Sorry meant to circle back around to this when I had the time.

@chfw
Copy link
Member

chfw commented Aug 18, 2020

That's alright. It was a show stopper hence I changed my mind to close it up.

@chfw
Copy link
Member

chfw commented Aug 19, 2020

I have also removed v0.7.9 from pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants