Implement a faster query for sorted samples with search enabled and editing disabled #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the samples query to call Neo4j directly
We previously used dataloader to make a single query for samples via the OGM. Otherwise, the `samples` and `samplesConnection` sub-queries would be call it twice. With the new approach, we use two slightly different queries to get samples data and the count of samples. We could use dataloader to access the oncotree cache, but this operation is very fast (< 0.05ms).
…ampleId column to the front
ao508
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply merges the
samples-query-optimizationbranch tomaster.