feat(core): Execution curation #10342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
# Conflicts: # packages/@n8n/permissions/src/types.ts # packages/cli/src/executions/execution.service.ts # packages/cli/src/executions/execution.types.ts # packages/editor-ui/src/components/MainHeader/WorkflowDetails.vue # packages/editor-ui/src/components/TagsDropdown.vue # packages/editor-ui/src/components/executions/workflow/WorkflowExecutionsCard.vue # packages/editor-ui/src/components/executions/workflow/WorkflowExecutionsList.vue # packages/editor-ui/src/stores/executions.store.ts
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ai-256-execution-curation-p0
|
| Run status |
|
| Run duration | 04m 45s |
| Commit |
|
| Committer | Eugene Molodkin |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
422
|
| View all changes introduced in this branch ↗︎ | |
# Conflicts: # packages/cli/test/integration/execution.service.integration.test.ts
OlegIvaniv
approved these changes
Sep 2, 2024
|
✅ All Cypress E2E specs passed |
tomi
approved these changes
Sep 2, 2024
| }); | ||
| const executions = await this.createQueryBuilder('execution') | ||
| .select('execution.id') | ||
| .where('execution.id NOT IN ' + annotatedExecutionsSubQuery.getQuery()) |
There was a problem hiding this comment.
nit: Could move the .getQuery() part to where this is defined and then here
Suggested change
| .where('execution.id NOT IN ' + annotatedExecutionsSubQuery.getQuery()) | |
| .where(`execution.id NOT IN (${annotatedExecutionsSubQuery})`) |
Comment on lines
+146
to
+163
| test('should not prune annotated executions', async () => { | ||
| const executions = [ | ||
| await createSuccessfulExecution(workflow), | ||
| await createSuccessfulExecution(workflow), | ||
| await createSuccessfulExecution(workflow), | ||
| ]; | ||
|
|
||
| await annotateExecution(executions[0].id, { vote: 'up' }, [workflow.id]); | ||
|
|
||
| await pruningService.softDeleteOnPruningCycle(); | ||
|
|
||
| const result = await findAllExecutions(); | ||
| expect(result).toEqual([ | ||
| expect.objectContaining({ id: executions[0].id, deletedAt: null }), | ||
| expect.objectContaining({ id: executions[1].id, deletedAt: expect.any(Date) }), | ||
| expect.objectContaining({ id: executions[2].id, deletedAt: null }), | ||
| ]); | ||
| }); |
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Sep 2, 2024
* master: fix(core): Flush responses for ai streaming endpoints (#10633) fix: Re-enable infra provisioning and teardown (no-changelog) (#10636) feat(core): Execution curation (#10342) fix(Webhook Node): Add tests for utils (no-changelog) (#10613) fix: Fixes to cloud benchmarks (no-changelog) (#10634) test: Add JS CodeNode benchmark scenario (#10632) refactor(editor): Migrate `MainSidebar.vue` to composition API (no-changelog) (#10538) build: Fix `cli` nodemon config (#10628) docs: Add 'benchmark' scope to PR Title Conventions documentation (#10624) ci: Fixes to benchmarks in cloud (#10626) test(editor): Increase test coverage for users settings page and modal (#10623) fix(Wait Node): Append n8n attribution option (#10585) refactor(editor): Migrate `NodeSettings.vue` to composition API (#10545) fix(editor): Add pinned data only to manual executions in execution view (#10605) ci: Omit benchmark scope commits from changelog (no-changelog) (#10618) fix: Disable errors obfuscation (no-changelog) (#10617) ci: Fix script name in gh workflow (#10619) ci: Fix nightly image not being pushed to ghcr (#10620)
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the execution annotation feature.
Here is an overview of the changes:
execution_annotations - annotation for executions
annotation_tag_entity - all annotation tags
execution_annotation_tags - connection between annotations and tags
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/AI-256/execution-curation-p0
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)