fix: Fixes to cloud benchmarks (no-changelog) #10634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So different postgres instances have their own data instead of reusing it from the previous run. Also fixes the permission issues in the data directory. If we let docker create the mounted dirs, they will be owned by root:root, and the containers won't have access to them. Hence we create them ourselves and run the containers using the current user and group
While the `az ssh vm` is more secure, it has multiple issues: - The access token expires in 10 mins, causing test failures: `ERROR: AADSTS700024: Client assertion is not within its valid time range` - It does not propagate the exit code, but instead always exits with 0 - It can't do `scp`, so we need to clone the repo. This makes local development more cumbersome - It logs all kinds of unnecessary stuff into stdout Hence this commits replaces `az ssh vm` with `ssh` and `scp`. Since the benchmark environment is a throwaway env without any critical data, it's not the biggest deals. We keep the private key hidden throughout the run anyways, so it's not leaked unless someone gains access to the GH runner.
tomi
changed the title
csuermann
approved these changes
Sep 2, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
fix-cloud-benchmarks
|
| Run status |
|
| Run duration | 04m 38s |
| Commit |
|
| Committer | Tomi Turtiainen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
422
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Sep 2, 2024
* master: fix(core): Flush responses for ai streaming endpoints (#10633) fix: Re-enable infra provisioning and teardown (no-changelog) (#10636) feat(core): Execution curation (#10342) fix(Webhook Node): Add tests for utils (no-changelog) (#10613) fix: Fixes to cloud benchmarks (no-changelog) (#10634) test: Add JS CodeNode benchmark scenario (#10632) refactor(editor): Migrate `MainSidebar.vue` to composition API (no-changelog) (#10538) build: Fix `cli` nodemon config (#10628) docs: Add 'benchmark' scope to PR Title Conventions documentation (#10624) ci: Fixes to benchmarks in cloud (#10626) test(editor): Increase test coverage for users settings page and modal (#10623) fix(Wait Node): Append n8n attribution option (#10585) refactor(editor): Migrate `NodeSettings.vue` to composition API (#10545) fix(editor): Add pinned data only to manual executions in execution view (#10605) ci: Omit benchmark scope commits from changelog (no-changelog) (#10618) fix: Disable errors obfuscation (no-changelog) (#10617) ci: Fix script name in gh workflow (#10619) ci: Fix nightly image not being pushed to ghcr (#10620)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contains the following changes:
So different postgres instances have their own data instead of
reusing it from the previous run. Also fixes the permission issues
in the data directory. If we let docker create the mounted dirs,
they will be owned by root:root, and the containers won't have
access to them. Hence we create them ourselves and run the containers
using the current user and group
While the
az ssh vmis more secure, it has multiple issues:ERROR: AADSTS700024: Client assertion is not within its valid time rangescp, so we need to clone the repo. This makes local development more cumbersomeHence this commits replaces
az ssh vmwithsshandscp. Since the benchmarkenvironment is a throwaway env without any critical data, it's not the biggest deals.
We keep the private key hidden throughout the run anyways, so it's not leaked unless
someone gains access to the GH runner.
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)