-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add 'benchmark' scope to PR Title Conventions documentation #10624
Conversation
| `feat` | A new feature | ✅ | | ||
| `fix` | A bug fix | ✅ | | ||
| `perf` | A code change that improves performance | ✅ | | ||
| `test` | Adding missing tests or correcting existing tests | ❌ | | ||
| `docs` | Documentation only changes | ❌ | | ||
| `refactor` | A behavior-neutral code change that neither fixes a bug nor adds a feature | ❌ | | ||
| `build` | Changes that affect the build system or external dependencies (TypeScript, Jest, pnpm, etc.) | ❌ | | ||
| `ci` | Changes to CI configuration files and scripts (e.g. Github actions) | ❌ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
@@ -55,7 +58,7 @@ The scope should specify the place of the commit change as long as the commit cl | |||
- n8n → n8n Node | |||
- `benchmark` - changes to the Benchmark cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the duplicate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
n8n Run #6692
Run Properties:
|
Project |
n8n
|
Branch Review |
pr-title-convention
|
Run status |
Passed #6692
|
Run duration | 04m 46s |
Commit |
a48a587867: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 csuermann 🗃️ e2e/*
|
Committer | Cornelius Suermann |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
422
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
* master: fix(core): Flush responses for ai streaming endpoints (#10633) fix: Re-enable infra provisioning and teardown (no-changelog) (#10636) feat(core): Execution curation (#10342) fix(Webhook Node): Add tests for utils (no-changelog) (#10613) fix: Fixes to cloud benchmarks (no-changelog) (#10634) test: Add JS CodeNode benchmark scenario (#10632) refactor(editor): Migrate `MainSidebar.vue` to composition API (no-changelog) (#10538) build: Fix `cli` nodemon config (#10628) docs: Add 'benchmark' scope to PR Title Conventions documentation (#10624) ci: Fixes to benchmarks in cloud (#10626) test(editor): Increase test coverage for users settings page and modal (#10623) fix(Wait Node): Append n8n attribution option (#10585) refactor(editor): Migrate `NodeSettings.vue` to composition API (#10545) fix(editor): Add pinned data only to manual executions in execution view (#10605) ci: Omit benchmark scope commits from changelog (no-changelog) (#10618) fix: Disable errors obfuscation (no-changelog) (#10617) ci: Fix script name in gh workflow (#10619) ci: Fix nightly image not being pushed to ghcr (#10620)
Got released with |
Adds 'benchmark' scope and improves some of the markdown formatting.