test(editor): Increase test coverage for users settings page and modal #10623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r00gm
changed the title
n8n-assistant
bot
added
n8n team
r00gm
changed the title
cstuncsik
reviewed
Aug 30, 2024
alexgrozav
requested changes
Aug 30, 2024
cstuncsik
reviewed
Aug 30, 2024
| } | ||
| : ReturnType<TStoreDef> => { | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| return useStore() as any; |
There was a problem hiding this comment.
I think you can omit type casting here to any, or if you want to do it, it could be TStoreDef
There was a problem hiding this comment.
this method is copy pasted from the documentation, but anyway i tried and it needs to be any.
the important part is that when used it correctly infers the store types
There was a problem hiding this comment.
I thought just to avoid using eslint disable comment because we're not using any
There was a problem hiding this comment.
And it is likely doesn't matter since the return type of the function already defined as ReturnType<TStoreDef>
There was a problem hiding this comment.
i agree but it doesn't work :(
cstuncsik
approved these changes
Aug 30, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
pay-1904-increaser-test-coverage-for-users-settings-page
|
| Run status |
|
| Run duration | 05m 14s |
| Commit |
|
| Committer | r00gm |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
422
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
alexgrozav
approved these changes
Aug 30, 2024
r00gm
deleted the
pay-1904-increaser-test-coverage-for-users-settings-page
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Sep 2, 2024
* master: fix(core): Flush responses for ai streaming endpoints (#10633) fix: Re-enable infra provisioning and teardown (no-changelog) (#10636) feat(core): Execution curation (#10342) fix(Webhook Node): Add tests for utils (no-changelog) (#10613) fix: Fixes to cloud benchmarks (no-changelog) (#10634) test: Add JS CodeNode benchmark scenario (#10632) refactor(editor): Migrate `MainSidebar.vue` to composition API (no-changelog) (#10538) build: Fix `cli` nodemon config (#10628) docs: Add 'benchmark' scope to PR Title Conventions documentation (#10624) ci: Fixes to benchmarks in cloud (#10626) test(editor): Increase test coverage for users settings page and modal (#10623) fix(Wait Node): Append n8n attribution option (#10585) refactor(editor): Migrate `NodeSettings.vue` to composition API (#10545) fix(editor): Add pinned data only to manual executions in execution view (#10605) ci: Omit benchmark scope commits from changelog (no-changelog) (#10618) fix: Disable errors obfuscation (no-changelog) (#10617) ci: Fix script name in gh workflow (#10619) ci: Fix nightly image not being pushed to ghcr (#10620)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This were more like and e2e test disguised as an Unit test.
Separated it into two so each one test their own logic.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-1904/increaser-test-coverage-for-users-settings-page
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)