Increase combined_transactions_size_limit to 4MiB #11582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow to send 4MiB of receipts over two consecutive chunks. Refs: [zulip discussion](https://near.zulipchat.com/#narrow/stream/308695-nearone.2Fprivate/topic/Transaction.20size.20limit/near/444712317)
bowenwang1996
pushed a commit
to near/NEPs
that referenced
this pull request
Jun 14, 2024
In near/nearcore#11582 we're increasing `combined_transactions_size_limit`, so let's update the NEP to match the implementation.
bowenwang1996
approved these changes
Jun 14, 2024
wacban
pushed a commit
that referenced
this pull request
Jun 17, 2024
This will allow to send 4MiB of receipts over two consecutive chunks. Refs: [zulip discussion](https://near.zulipchat.com/#narrow/stream/308695-nearone.2Fprivate/topic/Transaction.20size.20limit/near/444712317)
jancionear
added a commit
that referenced
this pull request
Jun 19, 2024
This will allow to send 4MiB of receipts over two consecutive chunks. (Also added the missing documentation about witness limits which caused a merge conflict) Refs: [zulip discussion](https://near.zulipchat.com/#narrow/stream/308695-nearone.2Fprivate/topic/Transaction.20size.20limit/near/444712317)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
The `MAX_COMPRESSED_STATE_WITNESS_SIZE` has been set to 32 MiB in #11511. Back then it was a reasonable choice, but since then we increased some of the runtime parameters, which increased the worst case witness size by ~17MiB. (#11582, #11629). I'd feel safer with a larger limit on the compressed witness size.
jancionear
added a commit
that referenced
this pull request
Jun 28, 2024
The `MAX_COMPRESSED_STATE_WITNESS_SIZE` has been set to 32 MiB in #11511. Back then it was a reasonable choice, but since then we increased some of the runtime parameters, which increased the worst case witness size by ~17MiB. (#11582, #11629). I'd feel safer with a larger limit on the compressed witness size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to send 4MiB of receipts over two consecutive chunks.
Refs: zulip discussion