chore(congestion_control) - increase max_congestion_missed_chunks to 5 - protocol upgrade #11629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tayfunelmas
approved these changes
Jun 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11629 +/- ##
==========================================
- Coverage 71.47% 71.46% -0.02%
==========================================
Files 788 788
Lines 160921 160921
Branches 160921 160921
==========================================
- Hits 115015 114997 -18
- Misses 40883 40898 +15
- Partials 5023 5026 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tayfunelmas
added a commit
that referenced
this pull request
Jun 20, 2024
…5 - protocol upgrade (#11629) Co-authored-by: Tayfun Elmas <tayfunelmas@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
The `MAX_COMPRESSED_STATE_WITNESS_SIZE` has been set to 32 MiB in #11511. Back then it was a reasonable choice, but since then we increased some of the runtime parameters, which increased the worst case witness size by ~17MiB. (#11582, #11629). I'd feel safer with a larger limit on the compressed witness size.
jancionear
added a commit
that referenced
this pull request
Jun 28, 2024
The `MAX_COMPRESSED_STATE_WITNESS_SIZE` has been set to 32 MiB in #11511. Back then it was a reasonable choice, but since then we increased some of the runtime parameters, which increased the worst case witness size by ~17MiB. (#11582, #11629). I'd feel safer with a larger limit on the compressed witness size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.