Increase MAX_COMPRESSED_STATE_WITNESS_SIZE to 48 MiB

[jancionear]

The MAX_COMPRESSED_STATE_WITNESS_SIZE has been set to 32 MiB in #11511. Back then it was a reasonable choice, but since then we increased some of the runtime parameters, which increased the worst case witness size by ~17MiB. (#11582, #11629). I'd feel safer with a larger limit on the compressed witness size.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.75%. Comparing base (cf00e1b) to head (3181517).
Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #11683      +/-   ##
==========================================
- Coverage   71.75%   71.75%   -0.01%     
==========================================
  Files         790      790              
  Lines      161830   161838       +8     
  Branches   161830   161838       +8     
==========================================
+ Hits       116114   116119       +5     
- Misses      40678    40681       +3     
  Partials     5038     5038              

Flag	Coverage Δ
backward-compatibility	0.23% <ø> (-0.01%)	⬇️
db-migration	0.23% <ø> (-0.01%)	⬇️
genesis-check	1.35% <ø> (-0.01%)	⬇️
integration-tests	37.80% <ø> (+0.01%)	⬆️
linux	69.16% <ø> (+0.01%)	⬆️
linux-nightly	71.23% <ø> (-0.01%)	⬇️
macos	52.63% <ø> (+0.03%)	⬆️
pytests	1.58% <ø> (-0.01%)	⬇️
sanity-checks	1.38% <ø> (-0.01%)	⬇️
unittests	66.34% <ø> (-0.02%)	⬇️
upgradability	0.28% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pugachAG]

LGTM, but I'd also increase MAX_UNCOMPRESSED_STATE_WITNESS_SIZE 2x to be 128mib, assuming compression is on avg decreases the size 2 times.
another nit: please update WITNESS_PARTS_CACHE_SIZE comment

[jancionear]

LGTM, but I'd also increase MAX_UNCOMPRESSED_STATE_WITNESS_SIZE 2x to be 128mib, assuming compression is on avg decreases the size 2 times. another nit: please update WITNESS_PARTS_CACHE_SIZE comment

You're right, they should be different. Let's set MAX_COMPRESSED_STATE_WITNESS_SIZE to 48 MiB and MAX_UNCOMPRESSED_STATE_WITNESS_SIZE to 64MiB. I don't expect uncompressed witnesses to be larger than 64 MiB.

Updated comment.