Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't use Timeout.timeout() #2147

Merged
merged 4 commits into from
Aug 2, 2023
Merged

don't use Timeout.timeout() #2147

merged 4 commits into from
Aug 2, 2023

Commits on Aug 1, 2023

  1. don't use Timeout.timeout() 

    (outside of `test/`) don't use `Timeout.timeout()` when the underlying
library has timeout functionality itself.

resolves #975
    @fallwith
    fallwith committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    193ea5a View commit details
    Browse the repository at this point in the history

  2. CHANGELOG for PR 2147 

    CHANGELOG for issue 975
    @fallwith
    fallwith committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    acbcb8c View commit details
    Browse the repository at this point in the history

  3. Utilization test: ignore extra net/http args 

    When yield phony AWS metadata checks, ignore all options sent to
Net::HTTP beyond address and port.
    @fallwith
    fallwith committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    42a4275 View commit details
    Browse the repository at this point in the history

  4. Net::HTTP timeouts: remove ssl timeouts, TODOs 

    * do not have Net::HTTP override OpenSSL specific timeouts
* add TODOs to remind us to clean things up once we specifically only
  target Ruby versions 2.6 and above
    @fallwith
    fallwith committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    607f6d5 View commit details
    Browse the repository at this point in the history