Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix apps menu on mobile #10853

Merged
merged 2 commits into from
Aug 30, 2018
Merged

Fix apps menu on mobile #10853

merged 2 commits into from
Aug 30, 2018

Conversation

skjnldsv
Copy link
Member

Fix #10851

@skjnldsv
Fix apps menu on mobile
f47b59a 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added design Design, UI, UX, etc. 3. to review Waiting for reviews regression labels Aug 25, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone Aug 25, 2018
@skjnldsv skjnldsv self-assigned this Aug 25, 2018
juliusknorr
juliusknorr previously requested changes Aug 25, 2018
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skjnldsv This breaks the other popovers on mobile:

image

@rullzer
Copy link
Member

rullzer commented Aug 26, 2018

@skjnldsv see the comment from @juliushaertl

@MorrisJobke MorrisJobke mentioned this pull request Aug 26, 2018
Merged
6 tasks
@skjnldsv
Fix apps menu and typo
10d51c3 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

@juliushaertl updated and fixed the typo!

@skjnldsv
Copy link
Member Author

@juliushaertl 🏓

@juliusknorr juliusknorr merged commit cdc4eee into master Aug 30, 2018
@juliusknorr juliusknorr deleted the apps-menu-fix-mobile branch August 30, 2018 12:51
@skjnldsv skjnldsv mentioned this pull request Sep 26, 2018
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Nov 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews design Design, UI, UX, etc. regression
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @rullzer @juliusknorr