Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix viewer integration styling #2371

Closed
juliusknorr opened this issue May 6, 2022 · 1 comment · Fixed by #2373
Closed

Fix viewer integration styling #2371

juliusknorr opened this issue May 6, 2022 · 1 comment · Fixed by #2373
Assignees
@vinicius73
Labels
3. to review bug Something isn't working

Comments

@juliusknorr
Copy link
Member

After nextcloud/viewer#1229 we need to adjust the css so that the viewer integration looks properly again.

Also needs to be backported for 24

Screenshot 2022-05-06 at 15 00 36
@juliusknorr
Copy link
Member Author

@vinicius73 Could you maybe have a look so that we have a fix in for the next release of 24 rather soonish?

The actual fix is probably similar to the one already done in files_pdfviewer https://github.com/nextcloud/files_pdfviewer/pull/597/files

@juliusknorr juliusknorr moved this to 📄 To do (5-20 entries) in 📝 Office team May 6, 2022
@vinicius73 vinicius73 self-assigned this May 6, 2022
vinicius73 pushed a commit that referenced this issue May 6, 2022
🐛 (#2371): fix viewer integration styling
b67dfd2 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
@vinicius73 vinicius73 mentioned this issue May 6, 2022
Merged
vinicius73 pushed a commit that referenced this issue May 9, 2022
💄 (#2371): fix css precedence
d5478eb 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Repository owner moved this from 📄 To do (5-20 entries) to ☑️ Done in 📝 Office team May 10, 2022
juliusknorr pushed a commit that referenced this issue May 17, 2022
@juliusknorr
🐛 (#2371): fix viewer integration styling
4e08dce 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
juliusknorr pushed a commit that referenced this issue May 17, 2022
@juliusknorr
💄 (#2371): fix css precedence
b106ac3 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
nextcloud-command pushed a commit that referenced this issue May 17, 2022
@nextcloud-command
💄 (#2371): fix css precedence
70e8a53 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinicius73 vinicius73

Labels
3. to review bug Something isn't working
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 fix viewer integration styling nextcloud/text
2 participants
@vinicius73 @juliusknorr