Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix viewer integration styling #2373

Merged
merged 5 commits into from
May 10, 2022

Conversation

vinicius73
Copy link
Member

@vinicius73 vinicius73 commented May 6, 2022

Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
@vinicius73 vinicius73 added bug Something isn't working 3. to review labels May 6, 2022
@vinicius73
Copy link
Member Author

/compile ament

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen
Copy link
Contributor

szaimen commented May 8, 2022

How does it look on mobile?

@juliusknorr
Copy link
Member

Screenshot 2022-05-09 at 08 11 54

Now I have a black bar at the bottom ;)

Vinicius Reis added 2 commits May 9, 2022 08:55
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
@vinicius73
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@vinicius73
Copy link
Member Author

How does it look on mobile?

@szaimen

image

@szaimen
Copy link
Contributor

szaimen commented May 9, 2022

How does it look on mobile?

@szaimen

image

looks good, thanks! However some icons are missing?

@vinicius73
Copy link
Member Author

Looks related to #2374 @szaimen

@szaimen
Copy link
Contributor

szaimen commented May 9, 2022

Looks related to #2374 @szaimen

yes indeed but I meant these:
image

@vinicius73
Copy link
Member Author

Nothing wrong @szaimen

It is intentional, from #2294

image

@szaimen
Copy link
Contributor

szaimen commented May 9, 2022

Nothing wrong @szaimen

It is intentional, from #2294

image

Ah okay, great! :)

@juliusknorr juliusknorr merged commit 842fbe7 into master May 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the 2371-fix-viewer-integration-styling branch May 10, 2022 16:50
@juliusknorr
Copy link
Member

/backport to stable24

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review backported successfully backported bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix viewer integration styling
5 participants