Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix design update after 5 vue components updgrade #1229

Merged
merged 2 commits into from
May 3, 2022
Merged

Fix design update after 5 vue components updgrade #1229

merged 2 commits into from
May 3, 2022

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv added bug Something isn't working regression Regression of a previous working feature design Related to the design 3. to review Waiting for reviews labels Apr 29, 2022
@skjnldsv skjnldsv added this to the Nextcloud 25 milestone Apr 29, 2022
@skjnldsv skjnldsv requested review from szaimen and a team April 29, 2022 07:32
@skjnldsv skjnldsv self-assigned this Apr 29, 2022
@skjnldsv skjnldsv requested review from artonge and vanpertsch and removed request for a team April 29, 2022 07:32
@skjnldsv skjnldsv added the high High priority label Apr 29, 2022
@skjnldsv
Copy link
Member Author

/rebase

szaimen
szaimen reviewed Apr 29, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well for videos and pictures but it seems to break the pdfviewer:
image

@skjnldsv
Fix design update after 5 vue components updgrade
423c1fa 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv added a commit to nextcloud/files_pdfviewer that referenced this pull request May 3, 2022
@skjnldsv
Adapt layout for nextcloud/viewer#1229
3cf9741 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv mentioned this pull request May 3, 2022
Merged
@skjnldsv skjnldsv requested a review from szaimen May 3, 2022 08:08
@skjnldsv
Copy link
Member Author

skjnldsv commented May 3, 2022

works well for videos and pictures but it seems to break the pdfviewer: image

Fix in nextcloud/files_pdfviewer#596

@skjnldsv
Copy link
Member Author

skjnldsv commented May 3, 2022

/backport to stable24

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label May 3, 2022
@skjnldsv skjnldsv force-pushed the fix/design-modal branch from e6cedde to 423c1fa Compare May 3, 2022 08:09
nextcloud-command pushed a commit to nextcloud/files_pdfviewer that referenced this pull request May 3, 2022
@skjnldsv @nextcloud-command
Adapt layout for nextcloud/viewer#1229
1b99e64 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv force-pushed the fix/design-modal branch from b8a7383 to 6e912a4 Compare May 3, 2022 08:39
@skjnldsv
Update tests
634a20c 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/design-modal branch from 6e912a4 to 634a20c Compare May 3, 2022 09:04
backportbot-nextcloud bot pushed a commit to nextcloud/files_pdfviewer that referenced this pull request May 3, 2022
@skjnldsv @backportbot-nextcloud
Adapt layout for nextcloud/viewer#1229
b8d1a7d 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv merged commit cd71d93 into master May 3, 2022
@skjnldsv skjnldsv deleted the fix/design-modal branch May 3, 2022 09:17
@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@szaimen szaimen mentioned this pull request May 3, 2022
Merged
@skjnldsv skjnldsv mentioned this pull request May 3, 2022
Merged
This was referenced May 6, 2022
Closed
Closed
@vinicius73 vinicius73 mentioned this pull request May 6, 2022
Merged
@juliusknorr juliusknorr mentioned this pull request May 17, 2022
Open
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@vanpertsch vanpertsch Awaiting requested review from vanpertsch

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working design Related to the design high High priority regression Regression of a previous working feature
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @artonge @szaimen