Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bam2fastq10x to handle multiplexed samples #6702

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

herpov
Copy link
Contributor

@herpov herpov commented Sep 27, 2024

Changes

Currently, the module expects converted files to be located in the working directory prefixed with a given label. However, converting multiplexed samples result in nested directory structure. The prefix argument is used to name the top level directory. In the next level are two directories, one for GEX and one for CMO reads.

Thus, the update is simply changing the output path to expect a nested directory and collect all .fastq.gz files.

PR checklist

Closes #6725

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@herpov
Copy link
Contributor Author

herpov commented Oct 2, 2024

@grst, here is the PR I have created for the bamtofastq10x module. Do you know who is most relevant to ask for review on this?

@grst
Copy link
Member

grst commented Oct 2, 2024

@BlueBicycleBlog is listed as maintainer in the meta.yaml

@SPPearce SPPearce added this pull request to the merge queue Oct 3, 2024
Merged via the queue into nf-core:master with commit 2d82007 Oct 3, 2024
12 checks passed
@herpov herpov deleted the feat/bamtofastq10x-outdir branch October 4, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update BAMTOFASTQ10X for multiplexed samples
3 participants