[minor] update: generate appropriate error for no measurement configuration/results #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshini-senthil
requested review from
dixonjoel,
aepete and
jasonmreding
as code owners
|
Before: |
|
Before: |
dixonjoel
approved these changes
Oct 7, 2024
jasonmreding
approved these changes
Oct 7, 2024
Source/Generator/_MeasurementClient Utility/Client Generator Error Strings Global.vi
Show resolved
Hide resolved
varshini-senthil
force-pushed
the
users/varshini/client-error-for-no-configuration-results
branch
from
48e408b
to
e1037fc
Compare
varshini-senthil
deleted the
users/varshini/client-error-for-no-configuration-results
branch
dixonjoel
pushed a commit
that referenced
this pull request
Oct 18, 2024
…esults (#613) * feat: add error for no measurement configuration/results * refactor: address Jason's comment * rebase branch 'users/varshini/client-error-for-no-configuration-results' to main
1 task
dixonjoel
added a commit
that referenced
this pull request
Oct 18, 2024
* Measurement Client Generator | Stream response support for the measurement client (#611) * refactor: split the client template to 5 VIs * refactor: update scripting logic * refactor: cleanup client template * feat: create Run Client Stream.vi * feat: implement scripting logic for stream measure * docs: add documentation for client template VIs * refactor: remove Run Client and have stream for both * docs: add documentation for other controls * refactor: address review comments * update: invalid client name warning handling (#614) * refactor: update invalid client name warning handling * test: update the automated test case for duplicate client name check * test: update the result message in testcase * update: generate appropriate error for no measurement configuration/results (#613) * feat: add error for no measurement configuration/results * refactor: address Jason's comment * rebase branch 'users/varshini/client-error-for-no-configuration-results' to main * [High Priority] Added cancel support to measurement client (#612) * refactor: split the client template to 5 VIs * refactor: update scripting logic * refactor: cleanup client template * feat: create Run Client Stream.vi * feat: implement scripting logic for stream measure * docs: add documentation for client template VIs * refactor: remove Run Client and have stream for both * Feat: Add cancel support to measurement client * docs: add documentation for other controls * refactor: address review comments * Fix: Handle errors while generating cancel user event * Fix: Update documentation * Fix: Wiring * Fix: Rename stop measurement client VI * Fix: Merge conflicts * Fix: Handle error cases from Read Measurement * Fix: FP cleanup for Run Client VI * Fix: Abort Measurement VI renaming * Fix: Minor documentation updates * Fix: Error documentation related updates * Fix: Minor documentation updates --------- Co-authored-by: varshini-senthil <varshini.senthilkumar@ni.com> * [Minor] Added refresh support to measurement client (#615) * Feat: Add refresh support to measurement client * Feat: Disable Create Measurement button on refresh * Fix: Revert error messages change * Fix: Minor refactoring * Fix: Set mouse busy while refreshing * Fix: Update refresh button * Fix: Make Refresh button as typedef * Fix: Update scope of Refresh button typedef to private * Add Sparse Enum support to Measurement Client (#616) * feat: add support for sparse enum as ring control * docs: update documentation * refactor: update indicator name * refactor: address Joel's comment * refactor: revert the changes to 'enum items' * refactor: address improvement comments * [Minor] Added Select all support to measurement client (#618) * Feat: Add Select all support to measurement client * Fix: Use -2 to traverse all rows * Fix: Set the width of the column when refreshing * Fix: Update warning message * Update readme doc for Measurement Plug-In Client generator (#620) * docs: update readme documentation --------- Co-authored-by: varshini-senthil <varshini.senthilkumar@ni.com> Co-authored-by: MounikaBattu17 <126869186+MounikaBattu17@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Client Generator Error Strings Global.vito indicate failure of client creation, due to no measurement configuration/results parameter in the measurement.Get Default Value.viandUpdate Measurement from Metadata.vito check for empty configuration and results metadata respectively and generate appropriate error.Why should this Pull Request be merged?
Context
The niswitch_control_relays example measurement in python has no results parameter. This is a special case for the LabVIEW client generator, as measurements with no configuration/results controls is not supported in LabVIEW. This will cause the client generation to fail with the
1055: Object reference is invaliderror, during update of the configuration/results controls.What testing has been done?