-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Releases/3.1] Cherry pick several PRs into the release branch #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ement client (#611) * refactor: split the client template to 5 VIs * refactor: update scripting logic * refactor: cleanup client template * feat: create Run Client Stream.vi * feat: implement scripting logic for stream measure * docs: add documentation for client template VIs * refactor: remove Run Client and have stream for both * docs: add documentation for other controls * refactor: address review comments
* refactor: update invalid client name warning handling * test: update the automated test case for duplicate client name check * test: update the result message in testcase
…esults (#613) * feat: add error for no measurement configuration/results * refactor: address Jason's comment * rebase branch 'users/varshini/client-error-for-no-configuration-results' to main
* refactor: split the client template to 5 VIs * refactor: update scripting logic * refactor: cleanup client template * feat: create Run Client Stream.vi * feat: implement scripting logic for stream measure * docs: add documentation for client template VIs * refactor: remove Run Client and have stream for both * Feat: Add cancel support to measurement client * docs: add documentation for other controls * refactor: address review comments * Fix: Handle errors while generating cancel user event * Fix: Update documentation * Fix: Wiring * Fix: Rename stop measurement client VI * Fix: Merge conflicts * Fix: Handle error cases from Read Measurement * Fix: FP cleanup for Run Client VI * Fix: Abort Measurement VI renaming * Fix: Minor documentation updates * Fix: Error documentation related updates * Fix: Minor documentation updates --------- Co-authored-by: varshini-senthil <varshini.senthilkumar@ni.com>
* Feat: Add refresh support to measurement client * Feat: Disable Create Measurement button on refresh * Fix: Revert error messages change * Fix: Minor refactoring * Fix: Set mouse busy while refreshing * Fix: Update refresh button * Fix: Make Refresh button as typedef * Fix: Update scope of Refresh button typedef to private
* feat: add support for sparse enum as ring control * docs: update documentation * refactor: update indicator name * refactor: address Joel's comment * refactor: revert the changes to 'enum items' * refactor: address improvement comments
* Feat: Add Select all support to measurement client * Fix: Use -2 to traverse all rows * Fix: Set the width of the column when refreshing * Fix: Update warning message
* docs: update readme documentation
dixonjoel
requested review from
aepete,
jasonmreding and
nstokes-nati
as code owners
October 18, 2024 16:22
DavidCurtiss
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Cherry-pick these commits into the releases/3.1 branch
a3dd359 (#611)
5f7661d (#614)
dffdaab (#613)
2427774 (#612)
2317ff1 (#615)
146cc77 (#616)
f5f929d (#618)
62cfc8e (#620)
Why should this Pull Request be merged?
Update the releases/3.1 branch prior to making a new release.
What testing has been done?
None. PR testing.