Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Added Select all support to measurement client #618

Merged
merged 4 commits into from
Oct 14, 2024
Merged

[Minor] Added Select all support to measurement client #618

merged 4 commits into from
Oct 14, 2024

Conversation

MounikaBattu17
Copy link
Contributor

@MounikaBattu17 MounikaBattu17 commented Oct 10, 2024 •
edited
Loading

  • This contribution adheres to CONTRIBUTING.md. (Required)
  • Automatically post PR comments with images for G code changes? (Recommended for small changes)

What does this Pull Request accomplish?

Added Select All measurements support to Measurement Client tool.

Why should this Pull Request be merged?

  • Added a Select All checkbox in Available Measurements listbox header. Clicking on this icon should select all measurements in the list box.
  • Behaviour of this checkbox:
    • Select All checkbox is disabled if no measurements are available.
    • Upon checking this checkbox, all measurements in the list are selected.
    • Upon unchecking this checkbox, all measurements in the list are unselected.
    • Select All checkbox is checked if all measurements in the list are selected.
    • Select All checkbox is unchecked if any measurement in the list is not selected.
    • Upon Refresh, Select All is either unchecked or, disabled if no measurements are available.
    • Other functionalities like client name validation, Create client button enable/disable, Warning visibility, will be working as expected for Select All changes.
  • Code changes:
    • Added a new event for select All value change, which will update the measurements icons, client name text color, create client button state, warning visibility based on select all boolean.
    • Updated code in Available Measurements Mouse Down event to check/uncheck Select All checkbox based on measurements selection.
    • Updated Refresh Value change event to either disable(if no measurements available) or uncheck select All checkbox.

What testing has been done?

Manually verified the Select All functionality.

@MounikaBattu17
Copy link
Contributor Author

Select All support

@dixonjoel
Copy link
Collaborator

When I see the error message with the invalid characters, it doesn't seem to include '.' or '_'. Why is 'ni.examples.GameOfLife_Python' invalid?

@Avinash2Suresh
Copy link
Contributor

When I see the error message with the invalid characters, it doesn't seem to include '.' or '_'. Why is 'ni.examples.GameOfLife_Python' invalid?

The client name for 'ni.examples.GameOfLife_Python' is not unique. The active project already has an existing library with the same name.

@dixonjoel
Copy link
Collaborator

When I see the error message with the invalid characters, it doesn't seem to include '.' or '_'. Why is 'ni.examples.GameOfLife_Python' invalid?

The client name for 'ni.examples.GameOfLife_Python' is not unique. The active project already has an existing library with the same name.

That's a little misleading - the error message says it has invalid characters. Do we have a different message for non-unique library?

@MounikaBattu17
Copy link
Contributor Author

MounikaBattu17 commented Oct 14, 2024 •
edited
Loading

That's a little misleading - the error message says it has invalid characters. Do we have a different message for non-unique library?

Updated the error message to provide better clarity on the error.

@MounikaBattu17 MounikaBattu17 merged commit f5f929d into main Oct 14, 2024
5 checks passed
@Avinash2Suresh Avinash2Suresh deleted the users/mounika/client-add-select-all-support branch October 16, 2024 10:18
dixonjoel pushed a commit that referenced this pull request Oct 18, 2024
@MounikaBattu17 @dixonjoel
[Minor] Added Select all support to measurement client (#618)
39d86d0 
* Feat: Add Select all support to measurement client

* Fix: Use -2 to traverse all rows

* Fix: Set the width of the column when refreshing

* Fix: Update warning message
@dixonjoel dixonjoel mentioned this pull request Oct 18, 2024
Merged
1 task
dixonjoel added a commit that referenced this pull request Oct 18, 2024
@dixonjoel @varshini-senthil @MounikaBattu17
[Releases/3.1] Cherry pick several PRs into the release branch (#624)
432135c 
* Measurement Client Generator | Stream response support for the measurement client  (#611)

* refactor: split the client template to 5 VIs

* refactor: update scripting logic

* refactor: cleanup client template

* feat: create Run Client Stream.vi

* feat: implement scripting logic for stream measure

* docs: add documentation for client template VIs

* refactor: remove Run Client and have stream for both

* docs: add documentation for other controls

* refactor: address review comments

* update: invalid client name warning handling (#614)

* refactor: update invalid client name warning handling

* test: update the automated test case for duplicate client name check

* test: update the result message in testcase

* update: generate appropriate error for no measurement configuration/results (#613)

* feat: add error for no measurement configuration/results

* refactor: address Jason's comment

* rebase branch 'users/varshini/client-error-for-no-configuration-results' to main

* [High Priority] Added cancel support to measurement client (#612)

* refactor: split the client template to 5 VIs

* refactor: update scripting logic

* refactor: cleanup client template

* feat: create Run Client Stream.vi

* feat: implement scripting logic for stream measure

* docs: add documentation for client template VIs

* refactor: remove Run Client and have stream for both

* Feat: Add cancel support to measurement client

* docs: add documentation for other controls

* refactor: address review comments

* Fix: Handle errors while generating cancel user event

* Fix: Update documentation

* Fix: Wiring

* Fix: Rename stop measurement client VI

* Fix: Merge conflicts

* Fix: Handle error cases from Read Measurement

* Fix: FP cleanup for Run Client VI

* Fix: Abort Measurement VI renaming

* Fix: Minor documentation updates

* Fix: Error documentation related updates

* Fix: Minor documentation updates

---------

Co-authored-by: varshini-senthil <varshini.senthilkumar@ni.com>

* [Minor] Added refresh support to measurement client (#615)

* Feat: Add refresh support to measurement client

* Feat: Disable Create Measurement button on refresh

* Fix: Revert error messages change

* Fix: Minor refactoring

* Fix: Set mouse busy while refreshing

* Fix: Update refresh button

* Fix: Make Refresh button as typedef

* Fix: Update scope of Refresh button typedef to private

* Add Sparse Enum support to Measurement Client (#616)

* feat: add support for sparse enum as ring control

* docs: update documentation

* refactor: update indicator name

* refactor: address Joel's comment

* refactor: revert the changes to 'enum items'

* refactor: address improvement comments

* [Minor] Added Select all support to measurement client (#618)

* Feat: Add Select all support to measurement client

* Fix: Use -2 to traverse all rows

* Fix: Set the width of the column when refreshing

* Fix: Update warning message

* Update readme doc for Measurement Plug-In Client generator (#620)

* docs: update readme documentation

---------

Co-authored-by: varshini-senthil <varshini.senthilkumar@ni.com>
Co-authored-by: MounikaBattu17 <126869186+MounikaBattu17@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prem-MysteryPro Prem-MysteryPro Prem-MysteryPro approved these changes

@dixonjoel dixonjoel dixonjoel approved these changes

@aepete aepete Awaiting requested review from aepete aepete is a code owner

@jasonmreding jasonmreding Awaiting requested review from jasonmreding jasonmreding is a code owner

@Avinash2Suresh Avinash2Suresh Awaiting requested review from Avinash2Suresh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MounikaBattu17 @dixonjoel @Avinash2Suresh @Prem-MysteryPro