Malicious behavior miner #132
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanBSC
force-pushed
the
malicious_behavior_miner
branch
from
4513f63
to
760bd68
Compare
NathanBSC
force-pushed
the
malicious_behavior_miner
branch
3 times, most recently
from
4e6b257
to
13c253f
Compare
Pla |
expected hard fork date:
Mainnet-HaberFix: 2024-09-26 02:02:00 AM UTC
Mainnet-Bohr: 2024-09-26 02:20:00 AM UTC
Draft release v1.4.14
only some necessary apis are implemented.
apply `Eth.Miner.GasCeil` to TxPool even the node did not enable `--mine` option Otherwise, there could be accmulated pending transactions in txpool. Take an example: - Currently, BSC testnet's block gaslimit is 70M, as 20M gas is reserved for SystemTxs, the maximum acceptable GasLimit for transaction is 50M. - TxPool recevied a transaction with GasLimit 60M, it would be accepted in TxPool but it will never be accepted by validators. Such kinds of transactions will be kept in txpool and gradually make the txpool overflowed
…b-chain#2679) Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.1.7.
Otherwise the node will be waiting for 500ms before the block fetcher keeps processing.
This PR tries to improve bnb-chain#2680 If the node did not set `Eth.Miner` in config.toml, the default GasCeil will be 30000000, it is not an accurate number for both BSC mainnet and testnet. Set it to 0 means disable the transaction GasLimit check, i.e. the TxPool will accept transactions with any GasLimit size.
others changes: - remove bsc-docker, as it is broken - remove light client, as it is no longer supported
…-chain#2461)" This reverts commit 0c0958f.
…heck eth/handler: remove duplicate check for lists in body
NathanBSC
force-pushed
the
malicious_behavior_miner
branch
from
13de488
to
c0130a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Malicious behavior miner
Rationale
just to see the diff between latest tag and this branch
Example
add an example CLI or API response...
Changes
Notable changes: