Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: simplify first-time contributors section of Collaborator Guide #24387

Closed
wants to merge 2 commits into from
Closed

doc: simplify first-time contributors section of Collaborator Guide #24387

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 16, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1628/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 16, 2018
refack
refack approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍simpler and better.
Just one suggestion: I put the "always" there intentionally. IMHO it can still be the first word of the paragraph without adding unnecessary complexity.

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 16, 2018
@Trott
Copy link
Member Author

Trott commented Nov 16, 2018

I put the "always" there intentionally. IMHO it can still be the first word of the paragraph without adding unnecessary complexity.

Sure, done.

refack
refack approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😀

@refack
Copy link
Contributor

refack commented Nov 16, 2018

Keeping the author ready fresh https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1638/

@refack refack added the meta Issues and PRs related to the general management of the project. label Nov 16, 2018
Trott added a commit to Trott/io.js that referenced this pull request Nov 18, 2018
@Trott
doc: simplify first-time contributors section of Collaborator Guide
282c5cf 
PR-URL: nodejs#24387
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@Trott
Copy link
Member Author

Trott commented Nov 18, 2018

Landed in 282c5cf.

@Trott Trott closed this Nov 18, 2018
@refack refack added landed and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 18, 2018
targos pushed a commit that referenced this pull request Nov 18, 2018
@Trott @targos
doc: simplify first-time contributors section of Collaborator Guide
c361495 
PR-URL: #24387
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Trott @rvagg
doc: simplify first-time contributors section of Collaborator Guide
5c4f569 
PR-URL: #24387
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@Trott @codebytere
doc: simplify first-time contributors section of Collaborator Guide
6fcf565 
PR-URL: #24387
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
doc: simplify first-time contributors section of Collaborator Guide
cb09396 
PR-URL: nodejs#24387
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@Trott @codebytere
doc: simplify first-time contributors section of Collaborator Guide
2734c20 
PR-URL: #24387
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the welcoming branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@starkwang starkwang starkwang approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@oyyd oyyd oyyd approved these changes

@fhinkel fhinkel fhinkel approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @nodejs-github-bot @refack @fhinkel @oyyd @vsemozhetbyt @starkwang @trivikr