Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] use NativeModuleLoader to compile all the bootstrappers #25446

Closed

Commits on Jan 10, 2019

  1. lib: remove internalBinding('config').pendingDeprecation

    Instead use
    `require('internal/options').getOptionValue('--pending-deprecation')`
    
    PR-URL: nodejs#24962
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    joyeecheung authored and BridgeAR committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    617bfe4 View commit details
    Browse the repository at this point in the history
  2. inspector: move process.binding to internalBinding

    In places of process.binding('inspector'), migrate code to adapt
    internalBinding.
    
    PR-URL: nodejs#24931
    Refs: nodejs#22160
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    BeniCheni authored and BridgeAR committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    c168672 View commit details
    Browse the repository at this point in the history
  3. util: inspect ArrayBuffers contents as well

    Inspecting an ArrayBuffer now also shows their binary contents.
    
    PR-URL: nodejs#25006
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    BridgeAR committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    dc4e5c5 View commit details
    Browse the repository at this point in the history
  4. lib: remove internal util._extends() usage

    This removes all internal calls to the deprecated `_extends()`
    function. It is slower than `Object.assign()` and the object spread
    notation since V8 6.8 and using the spread notation often also
    results in shorter code.
    
    PR-URL: nodejs#25105
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    BridgeAR committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    0c67a51 View commit details
    Browse the repository at this point in the history
  5. lib: expose all type checks from the internal types module

    Combine all type checks on the internal types module and do not use
    the types binding anywhere else anymore. This makes sure all of those
    checks exist when required.
    
    PR-URL: nodejs#25149
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    BridgeAR committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    e97acf7 View commit details
    Browse the repository at this point in the history
  6. buffer: inspect extra properties

    This makes sure extra properties on buffers are not ignored anymore
    when inspecting the buffer.
    
    PR-URL: nodejs#25150
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    95fa3c7 View commit details
    Browse the repository at this point in the history
  7. lib: move lib/console.js to lib/internal/console/constructor.js

    This is a broken commit: it's here so that git interpret this
    as a file move and preserve most of the history of the Console
    constructor.
    
    PR-URL: nodejs#24709
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and BridgeAR committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    7ff4402 View commit details
    Browse the repository at this point in the history
  8. console: split console into global.js and constructor.js

    Since we do not actually use the Console constructor to
    instantiate the global console, move the two piece of
    code into two different JS files for clarity, and make
    console.js a mere re-export of the global console.
    The hope is to make the global console, a namespace, more
    web-compatible while keeping the Console constructor
    available for backwards compatibility.
    
    PR-URL: nodejs#24709
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and BridgeAR committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    2f1f009 View commit details
    Browse the repository at this point in the history
  9. console: move the inspector console wrapping in a separate file

    Move the wrapping of the inspector console in a separate file
    for clarity. In addition, save the original console from the
    VM explicitly via an exported property
    `require('internal/console/inspector').consoleFromVM`
    that `require('inspector').console` can alias to it later,
    instead of hanging the original console onto `per_thread.js`
    during bootstrap and counting on that `per_thread.js`
    only gets evaluated once and gets cached.
    
    PR-URL: nodejs#24709
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and BridgeAR committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    6280cda View commit details
    Browse the repository at this point in the history
  10. console: add inspectOptions option

    Add an `inspectOptions` option to the `console` constructor. That
    way it's possible to define all inspection defaults for each
    `console` instance instead of relying on the `inspect()` defaults.
    
    PR-URL: nodejs#24978
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    BridgeAR committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    6bf7511 View commit details
    Browse the repository at this point in the history
  11. console: improve inspectOptions validation

    This commit adds stricter type checking to the inspectOptions
    option to the Console constructor.
    
    PR-URL: nodejs#25090
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and BridgeAR committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    049b24d View commit details
    Browse the repository at this point in the history
  12. process: provide dummy stdio for non-console Windows apps

    The only known condition where we could not provide appropriate
    stdio streams so far were non-console Windows applications.
    Since this issue has come up a few times in our issue tracker now,
    switch to providing dummy streams for these cases instead.
    
    If there are other valid cases in which `uv_guess_handle` fails,
    and where there is a more sensible way to provide stdio,
    we’ll probably still find out because the streams don’t work
    properly either way.
    
    Refs: nodejs/help#1251
    
    PR-URL: nodejs#20640
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    addaleax authored and BridgeAR committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    8d166c9 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2019

  1. Configuration menu
    Copy the full SHA
    c219b8f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f4dbe57 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7aeec97 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    48dfda7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    abfde34 View commit details
    Browse the repository at this point in the history
  6. Revert "src,lib: make process.binding('config') internal"

    This reverts commit 88a5449.
    joyeecheung committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    c5b2c31 View commit details
    Browse the repository at this point in the history
  7. Revert "lib: remove duplicated noop function"

    This reverts commit 1ec4f8d.
    joyeecheung committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    fb6f2f2 View commit details
    Browse the repository at this point in the history
  8. fs: make process.binding('fs') internal

    Refs: nodejs#22160
    
    PR-URL: nodejs#22478
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Masashi Hirano authored and joyeecheung committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    106b299 View commit details
    Browse the repository at this point in the history
  9. src: use NativeModuleLoader to compile all the bootstrappers

    This patch moves all the bootstrapper compilation to use
    NativeModuleLoader::CompileAndCall(). With this we no longer
    need to mess with the error decoration and handling any more -
    there is no point in handling the JS error occurred during bootstrapping
    by ourselves, we should just crash or let the VM handle it.
    
    PR-URL: nodejs#24775
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    joyeecheung committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    9a5984d View commit details
    Browse the repository at this point in the history
  10. lib: remove duplicated noop function

    PR-URL: nodejs#24770
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Weijia Wang <starkwang@126.com>
    ZYSzys authored and joyeecheung committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    373bbe7 View commit details
    Browse the repository at this point in the history
  11. src,lib: make process.binding('config') internal

    PR-URL: nodejs#23400
    Refs: nodejs#22160
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Masashi Hirano authored and joyeecheung committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    b6afa46 View commit details
    Browse the repository at this point in the history
  12. lib: remove unused NativeModule/NativeModule wraps

    We now compile the native modules in C++ so these are no longer
    used.
    
    PR-URL: nodejs#24904
    Refs:https://github.com/joyeecheung/node/commit/
    bd765d6
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    joyeecheung committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    5bc4592 View commit details
    Browse the repository at this point in the history
  13. inspector: move process.binding to internalBinding

    In places of process.binding('inspector'), migrate code to adapt
    internalBinding.
    
    PR-URL: nodejs#24931
    Refs: nodejs#22160
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    BeniCheni authored and joyeecheung committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    e05e5b3 View commit details
    Browse the repository at this point in the history
  14. os: move process.binding('os') to internalBinding

    PR-URL: nodejs#25087
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    briete authored and joyeecheung committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    181d03a View commit details
    Browse the repository at this point in the history
  15. lib: remove internalBinding('config').pendingDeprecation

    Instead use
    `require('internal/options').getOptionValue('--pending-deprecation')`
    
    PR-URL: nodejs#24962
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    joyeecheung committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    4cb9036 View commit details
    Browse the repository at this point in the history
  16. lib: expose all type checks from the internal types module

    Combine all type checks on the internal types module and do not use
    the types binding anywhere else anymore. This makes sure all of those
    checks exist when required.
    
    PR-URL: nodejs#25149
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    BridgeAR authored and joyeecheung committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    7d90f03 View commit details
    Browse the repository at this point in the history