-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add integration test for verifying a recursive proof onchain #3167
Conversation
b0cb1de
to
16d1c23
Compare
e4cedfd
to
4c0a05e
Compare
* master: (216 commits) chore(docs): address visibility issues in docs (#3643) chore: type formatting (#3618) fix: Restrict fill_internal_slices pass to acir functions (#3634) chore(docs): docs for v0.19.4 (#3601) feat: aztec-packages (#3626) chore: Move tests to the correct root (#3633) feat: Implement integer printing (#3577) fix: corrected the formatting of error message parameters in index out of bounds error (#3630) chore: Update ACIR artifacts (#3619) chore(debugger): Run debugger REPL in thread (#3611) chore: remove deprecated method (#3625) feat: Implement raw string literals (#3556) fix: docker builds (#3620) feat: Copy on write optimization for brillig (#3522) chore: separate methods in `dc_crate` into their own modules (#3585) feat: add special case for boolean AND in acir-gen (#3615) chore: Update ACIR artifacts (#3614) chore: remove `get_number_sequence` foreign calls (#3613) feat: Add package version to Nargo.toml metadata (#3427) chore(docs): Links to Aztec docs from errors (#3423) ...
03c946e
to
987cf9d
Compare
This adds a good chunk of time to the integration test CI however. (~3 mins) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests which aso test the proof size look like they should be in barretenberg, since that will change if we ever change the backend. I'm okay having this in as its one more layer of protection and we already have bb specific tests
* master: (124 commits) chore: add env var for test updates in nargo_fmt (#3638) chore: remove unnecessary conversions from `add_constant` (#3651) feat: Complex slice inputs for dynamic slice builtins (#3617) feat: Add `FieldElement::from<usize>` implementation (#3647) chore: fix relative paths in reease please (#3646) chore: add integration test for verifying a recursive proof onchain (#3167) chore: adding docs to release please (#3571) chore(ci): Fix publishing of ACVM crates (#3645) chore(docs): address visibility issues in docs (#3643) chore: type formatting (#3618) fix: Restrict fill_internal_slices pass to acir functions (#3634) chore(docs): docs for v0.19.4 (#3601) feat: aztec-packages (#3626) chore: Move tests to the correct root (#3633) feat: Implement integer printing (#3577) fix: corrected the formatting of error message parameters in index out of bounds error (#3630) chore: Update ACIR artifacts (#3619) chore(debugger): Run debugger REPL in thread (#3611) chore: remove deprecated method (#3625) feat: Implement raw string literals (#3556) ...
* master: (28 commits) feat: reuse witnesses more when interacting with memory (#3658) chore(ci): stop committing new acir artifacts (#3654) chore: add env var for test updates in nargo_fmt (#3638) chore: remove unnecessary conversions from `add_constant` (#3651) feat: Complex slice inputs for dynamic slice builtins (#3617) feat: Add `FieldElement::from<usize>` implementation (#3647) chore: fix relative paths in reease please (#3646) chore: add integration test for verifying a recursive proof onchain (#3167) chore: adding docs to release please (#3571) chore(ci): Fix publishing of ACVM crates (#3645) chore(docs): address visibility issues in docs (#3643) chore: type formatting (#3618) fix: Restrict fill_internal_slices pass to acir functions (#3634) chore(docs): docs for v0.19.4 (#3601) feat: aztec-packages (#3626) chore: Move tests to the correct root (#3633) feat: Implement integer printing (#3577) fix: corrected the formatting of error message parameters in index out of bounds error (#3630) chore: Update ACIR artifacts (#3619) chore(debugger): Run debugger REPL in thread (#3611) ...
Description
Problem*
Resolves
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.